Issue 401883006: Use the correct directory for reading test data in libaddressinput.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 401883006: Use the correct directory for reading test data in libaddressinput. (Closed)

Created:
6 years, 5 months ago by please use gerrit instead

Modified:
6 years, 5 months ago

Reviewers:
Evan Stade

CC:
chromium-reviews, glider+watch_chromium.org, timurrrr+watch_chromium.org, bruening+watch_chromium.org, groby-ooo-7-16, zhaoqin1

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Use the correct directory for reading test data in libaddressinput. This enables running libaddressinput unit tests on DrMemory bots, which work from the directory above src/. TBR=estade@chromium.org BUG=395169, 396203 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285093

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -18 lines)			Patch
	M	third_party/libaddressinput/libaddressinput.gyp	View		2 chunks	+2 lines, -1 line	0 comments	Download
	D	tools/valgrind/gtest_exclude/libaddressinput_unittests.gtest-drmemory_win32.txt	View		1 chunk	+0 lines, -17 lines	0 comments	Download

Total messages: 4 (0 generated)

please use gerrit instead

The CQ bit was checked by rouslan@chromium.org

6 years, 5 months ago (2014-07-23 18:02:29 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rouslan@chromium.org/401883006/80001

6 years, 5 months ago (2014-07-23 18:04:49 UTC) #3

Message was sent while issue was closed.

Change committed as 285093