third_party/libaddressinput/libaddressinput.gyp - Issue 401883006: Use the correct directory for reading test data in libaddressinput.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/libaddressinput/libaddressinput.gyp

Issue 401883006: Use the correct directory for reading test data in libaddressinput. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/libaddressinput/libaddressinput.gyp

diff --git a/third_party/libaddressinput/libaddressinput.gyp b/third_party/libaddressinput/libaddressinput.gyp

index 1745f5b81b613376c74fc82edf664a0c00251a6e..2ae761a8d18c32778d5f3b34a3939fca8a072608 100644

--- a/third_party/libaddressinput/libaddressinput.gyp

+++ b/third_party/libaddressinput/libaddressinput.gyp

@@ -4,6 +4,7 @@

{

'includes': ['src/cpp/libaddressinput.gypi'],

'variables': {

+ 'libaddressinput_test_data_dir%': 'src/third_party/libaddressinput/src/testdata',

'libaddressinput_util_files': [

'src/cpp/src/address_data.cc',

'src/cpp/src/address_field.cc',

@@ -144,7 +145,7 @@

'chromium/trie_unittest.cc',

'defines': [

- 'TEST_DATA_DIR="third_party/libaddressinput/src/testdata"',

+ 'TEST_DATA_DIR="<(libaddressinput_test_data_dir)"',

'include_dirs': [

'../../',

« no previous file with comments | « no previous file | tools/valgrind/gtest_exclude/libaddressinput_unittests.gtest-drmemory_win32.txt » ('j') | no next file with comments »