Issue 401813002: Revert "Bootstrapper::DetachGlobal also need to unset global_proxy's constructor to remove all refs…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 401813002: Revert "Bootstrapper::DetachGlobal also need to unset global_proxy's constructor to remove all refs… (Closed)

Created:
6 years, 5 months ago by dcarney

Modified:
6 years, 5 months ago

Reviewers:
titzer

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

Revert "Bootstrapper::DetachGlobal also need to unset global_proxy's constructor to remove all refs to context" This reverts r22460 for potentially breaking the mac webkit build. TBR=titzer@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=22474

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -1 line)			Patch
	M	src/bootstrapper.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 2 (0 generated)

dcarney

Committed patchset #1 manually as r22474 (presubmit successful).

6 years, 5 months ago (2014-07-18 11:47:42 UTC) #1

Message was sent while issue was closed.

lgtm