Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Side by Side Diff: src/bootstrapper.cc

Issue 401813002: Revert "Bootstrapper::DetachGlobal also need to unset global_proxy's constructor to remove all refs… (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/bootstrapper.h" 5 #include "src/bootstrapper.h"
6 6
7 #include "src/accessors.h" 7 #include "src/accessors.h"
8 #include "src/code-stubs.h" 8 #include "src/code-stubs.h"
9 #include "src/extensions/externalize-string-extension.h" 9 #include "src/extensions/externalize-string-extension.h"
10 #include "src/extensions/free-buffer-extension.h" 10 #include "src/extensions/free-buffer-extension.h"
(...skipping 337 matching lines...) Expand 10 before | Expand all | Expand 10 after
348 new_map->set_prototype(*proto); 348 new_map->set_prototype(*proto);
349 JSObject::MigrateToMap(object, new_map); 349 JSObject::MigrateToMap(object, new_map);
350 } 350 }
351 351
352 352
353 void Bootstrapper::DetachGlobal(Handle<Context> env) { 353 void Bootstrapper::DetachGlobal(Handle<Context> env) {
354 Factory* factory = env->GetIsolate()->factory(); 354 Factory* factory = env->GetIsolate()->factory();
355 Handle<JSGlobalProxy> global_proxy(JSGlobalProxy::cast(env->global_proxy())); 355 Handle<JSGlobalProxy> global_proxy(JSGlobalProxy::cast(env->global_proxy()));
356 global_proxy->set_native_context(*factory->null_value()); 356 global_proxy->set_native_context(*factory->null_value());
357 SetObjectPrototype(global_proxy, factory->null_value()); 357 SetObjectPrototype(global_proxy, factory->null_value());
358 global_proxy->map()->set_constructor(*factory->null_value());
359 } 358 }
360 359
361 360
362 static Handle<JSFunction> InstallFunction(Handle<JSObject> target, 361 static Handle<JSFunction> InstallFunction(Handle<JSObject> target,
363 const char* name, 362 const char* name,
364 InstanceType type, 363 InstanceType type,
365 int instance_size, 364 int instance_size,
366 MaybeHandle<JSObject> maybe_prototype, 365 MaybeHandle<JSObject> maybe_prototype,
367 Builtins::Name call) { 366 Builtins::Name call) {
368 Isolate* isolate = target->GetIsolate(); 367 Isolate* isolate = target->GetIsolate();
(...skipping 2318 matching lines...) Expand 10 before | Expand all | Expand 10 after
2687 return from + sizeof(NestingCounterType); 2686 return from + sizeof(NestingCounterType);
2688 } 2687 }
2689 2688
2690 2689
2691 // Called when the top-level V8 mutex is destroyed. 2690 // Called when the top-level V8 mutex is destroyed.
2692 void Bootstrapper::FreeThreadResources() { 2691 void Bootstrapper::FreeThreadResources() {
2693 ASSERT(!IsActive()); 2692 ASSERT(!IsActive());
2694 } 2693 }
2695 2694
2696 } } // namespace v8::internal 2695 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698