Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1140)

Issue 401713005: Move all geofencing code into its own module separate from geolocation. (Closed)

Created:
6 years, 5 months ago by Marijn Kruisselbrink
Modified:
6 years, 4 months ago
CC:
blink-reviews, mvanouwerkerk+watch_chromium.org, timvolodine
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Move all geofencing code into its own module separate from geolocation. BUG=383125 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179669

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : namespace #

Patch Set 4 : #

Total comments: 10

Patch Set 5 : address comments #

Total comments: 10

Patch Set 6 : address more comments #

Patch Set 7 : update test expectations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+99 lines, -259 lines) Patch
M LayoutTests/fast/dom/Geolocation/geofencing-not-implemented.html View 1 2 3 4 5 1 chunk +0 lines, -22 lines 0 comments Download
D LayoutTests/fast/dom/Geolocation/geofencing-not-implemented-expected.txt View 1 2 3 4 5 1 chunk +0 lines, -12 lines 0 comments Download
M LayoutTests/fast/dom/Window/window-properties-geolocation-expected.txt View 1 2 3 4 5 6 1 chunk +0 lines, -3 lines 0 comments Download
A + LayoutTests/geofencing/geofencing-not-implemented.html View 1 2 3 4 5 2 chunks +4 lines, -4 lines 0 comments Download
A + LayoutTests/geofencing/geofencing-not-implemented-expected.txt View 1 2 3 4 5 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/modules/geofencing/CircularRegion.h View 1 1 chunk +1 line, -1 line 0 comments Download
A + Source/modules/geofencing/CircularRegion.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
A + Source/modules/geofencing/CircularRegion.idl View 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/modules/geofencing/Geofencing.h View 1 2 3 4 5 2 chunks +12 lines, -9 lines 0 comments Download
A Source/modules/geofencing/Geofencing.cpp View 1 2 3 4 5 1 chunk +34 lines, -0 lines 0 comments Download
A + Source/modules/geofencing/Geofencing.idl View 1 chunk +5 lines, -3 lines 0 comments Download
A + Source/modules/geofencing/GeofencingRegion.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/modules/geofencing/GeofencingRegion.idl View 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/modules/geofencing/NavigatorGeofencing.h View 1 2 3 4 5 1 chunk +16 lines, -13 lines 0 comments Download
A + Source/modules/geofencing/NavigatorGeofencing.cpp View 1 2 3 4 5 1 chunk +17 lines, -17 lines 0 comments Download
A + Source/modules/geofencing/NavigatorGeofencing.idl View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
D Source/modules/geolocation/CircularRegion.h View 1 1 chunk +0 lines, -46 lines 0 comments Download
D Source/modules/geolocation/CircularRegion.cpp View 1 1 chunk +0 lines, -37 lines 0 comments Download
D Source/modules/geolocation/CircularRegion.idl View 1 chunk +0 lines, -17 lines 0 comments Download
D Source/modules/geolocation/GeofencingRegion.h View 1 1 chunk +0 lines, -32 lines 0 comments Download
D Source/modules/geolocation/GeofencingRegion.idl View 1 chunk +0 lines, -11 lines 0 comments Download
M Source/modules/geolocation/Geolocation.h View 1 3 chunks +0 lines, -6 lines 0 comments Download
M Source/modules/geolocation/Geolocation.cpp View 1 2 chunks +0 lines, -18 lines 0 comments Download
M Source/modules/geolocation/Geolocation.idl View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/modules/modules.gypi View 1 2 3 4 5 3 chunks +11 lines, -5 lines 0 comments Download

Messages

Total messages: 16 (0 generated)
Marijn Kruisselbrink
No real code changes, other than what is necessary to expose this as navigator.geofencing in ...
6 years, 5 months ago (2014-07-24 23:38:59 UTC) #1
Peter Beverloo
I'm fine with moving the code around, but not lgtm for functional changes until Elliot's ...
6 years, 5 months ago (2014-07-25 09:22:20 UTC) #2
Marijn Kruisselbrink
ptal https://codereview.chromium.org/401713005/diff/60001/LayoutTests/http/tests/geofencing/service-worker.html File LayoutTests/http/tests/geofencing/service-worker.html (right): https://codereview.chromium.org/401713005/diff/60001/LayoutTests/http/tests/geofencing/service-worker.html#newcode1 LayoutTests/http/tests/geofencing/service-worker.html:1: <!DOCTYPE html> On 2014/07/25 09:22:19, Peter Beverloo wrote: ...
6 years, 4 months ago (2014-07-30 23:40:55 UTC) #3
Peter Beverloo
+Elliot as a FYI. lgtm since this moves the code out of geolocation/, so further ...
6 years, 4 months ago (2014-08-05 21:12:43 UTC) #4
Michael van Ouwerkerk
https://codereview.chromium.org/401713005/diff/80001/LayoutTests/fast/dom/Geolocation/geofencing-not-implemented.html File LayoutTests/fast/dom/Geolocation/geofencing-not-implemented.html (right): https://codereview.chromium.org/401713005/diff/80001/LayoutTests/fast/dom/Geolocation/geofencing-not-implemented.html#newcode17 LayoutTests/fast/dom/Geolocation/geofencing-not-implemented.html:17: shouldReject(navigator.geofencing.registerRegion(new CircularRegion({latitude: 37.421999, longitude: -122.084015}))); As we now use ...
6 years, 4 months ago (2014-08-06 17:10:43 UTC) #5
Michael van Ouwerkerk
PS: please also update the CL description.
6 years, 4 months ago (2014-08-06 17:36:22 UTC) #6
Marijn Kruisselbrink
https://codereview.chromium.org/401713005/diff/80001/LayoutTests/fast/dom/Geolocation/geofencing-not-implemented.html File LayoutTests/fast/dom/Geolocation/geofencing-not-implemented.html (right): https://codereview.chromium.org/401713005/diff/80001/LayoutTests/fast/dom/Geolocation/geofencing-not-implemented.html#newcode17 LayoutTests/fast/dom/Geolocation/geofencing-not-implemented.html:17: shouldReject(navigator.geofencing.registerRegion(new CircularRegion({latitude: 37.421999, longitude: -122.084015}))); On 2014/08/06 17:10:43, Michael ...
6 years, 4 months ago (2014-08-06 18:27:19 UTC) #7
Michael van Ouwerkerk
lgtm, thanks!
6 years, 4 months ago (2014-08-06 18:44:47 UTC) #8
Marijn Kruisselbrink
+abarth for modules/ OWNERS
6 years, 4 months ago (2014-08-06 21:26:58 UTC) #9
abarth-chromium
rslgtm
6 years, 4 months ago (2014-08-06 21:56:44 UTC) #10
Marijn Kruisselbrink
The CQ bit was checked by mek@chromium.org
6 years, 4 months ago (2014-08-06 22:04:24 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mek@chromium.org/401713005/120001
6 years, 4 months ago (2014-08-06 22:04:31 UTC) #12
Marijn Kruisselbrink
The CQ bit was checked by mek@chromium.org
6 years, 4 months ago (2014-08-06 22:39:13 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mek@chromium.org/401713005/140001
6 years, 4 months ago (2014-08-06 22:39:56 UTC) #14
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 4 months ago (2014-08-07 00:06:39 UTC) #15
commit-bot: I haz the power
6 years, 4 months ago (2014-08-07 01:02:09 UTC) #16
Message was sent while issue was closed.
Change committed as 179669

Powered by Google App Engine
This is Rietveld 408576698