LayoutTests/fast/dom/Geolocation/geofencing-not-implemented.html - Issue 401713005: Move all geofencing code into its own module separate from geolocation.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/dom/Geolocation/geofencing-not-implemented.html

Issue 401713005: Move all geofencing code into its own module separate from geolocation. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: address comments Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <html>	2 <html>

3 <head>	3 <head>

4 <script src="../../../resources/js-test.js"></script>	4 <script src="../../../resources/js-test.js"></script>

5 </head>	5 </head>

6 <body>	6 <body>

7 <script>	7 <script>

8 description("Tests that all geofencing methods always reject.");	8 description("Tests that all geofencing methods always reject.");

9	9

10 function shouldReject(promise)	10 function shouldReject(promise)

11 {	11 {

12 promise.then(	12 promise.then(

13 function() { testFailed("Promise unexpectedly resolved."); },	13 function() { testFailed("Promise unexpectedly resolved."); },

14 function() { testPassed("Promise rejected as expected."); });	14 function() { testPassed("Promise rejected as expected."); });

15 }	15 }

16	16

17 shouldReject(navigator.geolocation.registerRegion(new CircularRegion({latitude: 37.421999, longitude: -122.084015})));	17 shouldReject(navigator.geofencing.registerRegion(new CircularRegion({latitude: 3 7.421999, longitude: -122.084015})));
	Michael van Ouwerkerk 2014/08/06 17:10:43 As we now use a separate geofencing module, this t As we now use a separate geofencing module, this test should also be in a separate geofencing directory. The fast/dom stuff is an old pattern that serves no purpose anymore afaik, so I'd suggest: LayoutTests/geofencing/geofencing-not-implemented.html Marijn Kruisselbrink 2014/08/06 18:27:18 Done. Show quoted text On 2014/08/06 17:10:43, Michael van Ouwerkerk wrote: > As we now use a separate geofencing module, this test should also be in a > separate geofencing directory. The fast/dom stuff is an old pattern that serves > no purpose anymore afaik, so I'd suggest: > LayoutTests/geofencing/geofencing-not-implemented.html Done.
18 shouldReject(navigator.geolocation.unregisterRegion(""));	18 shouldReject(navigator.geofencing.unregisterRegion(""));

19 shouldReject(navigator.geolocation.getRegisteredRegions());	19 shouldReject(navigator.geofencing.getRegisteredRegions());

20 </script>	20 </script>

21 </body>	21 </body>

22 </html>	22 </html>

OLD	NEW

« no previous file with comments | « no previous file | Source/modules/geofencing/CircularRegion.h » ('j') | Source/modules/geofencing/Geofencing.h » ('J')