Issue 401703004: Don't Initialize power data provider when client detatched

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 401703004: Don't Initialize power data provider when client detatched (Closed)

Created:
6 years, 5 months ago by Pan

Modified:
6 years, 5 months ago

Reviewers:
pfeldman

CC:
chromium-reviews, vsevik, jam, yurys, paulirish+reviews_chromium.org, darin-cc_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Don't Initialize power data provider when client detatched It was forced to unregister power handler from power profiler service when detached, unfortunately, GetInstance() of singleton method initialized the service without intention. This change makes the handler unregister itself only when it has registered. BUG=394609 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284388

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -3 lines)			Patch
	M	content/browser/devtools/devtools_power_handler.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	content/browser/devtools/devtools_power_handler.cc	View		5 chunks	+8 lines, -3 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Pan

The un-willed power profiler service initialization caused inspector layout test logged errors on windows, and ...

6 years, 5 months ago (2014-07-18 09:21:44 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pan.deng@intel.com/401703004/1

6 years, 5 months ago (2014-07-20 23:51:23 UTC) #4

Message was sent while issue was closed.

Change committed as 284388

Expand Messages | Collapse Messages