Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Unified Diff: content/browser/devtools/devtools_power_handler.cc

Issue 401703004: Don't Initialize power data provider when client detatched (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/devtools/devtools_power_handler.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/devtools/devtools_power_handler.cc
diff --git a/content/browser/devtools/devtools_power_handler.cc b/content/browser/devtools/devtools_power_handler.cc
index 4a72296967cb320ab190d713569d225d6ac418f6..339ead93fcb10d53b27f5b540659a88af9c0f1d8 100644
--- a/content/browser/devtools/devtools_power_handler.cc
+++ b/content/browser/devtools/devtools_power_handler.cc
@@ -11,7 +11,8 @@
namespace content {
-DevToolsPowerHandler::DevToolsPowerHandler() {
+DevToolsPowerHandler::DevToolsPowerHandler()
+ : is_profiling_(false) {
RegisterCommandHandler(devtools::Power::start::kName,
base::Bind(&DevToolsPowerHandler::OnStart,
base::Unretained(this)));
@@ -27,7 +28,8 @@ DevToolsPowerHandler::DevToolsPowerHandler() {
}
DevToolsPowerHandler::~DevToolsPowerHandler() {
- PowerProfilerService::GetInstance()->RemoveObserver(this);
+ if (is_profiling_)
+ PowerProfilerService::GetInstance()->RemoveObserver(this);
}
void DevToolsPowerHandler::OnPowerEvent(const PowerEventVector& events) {
@@ -57,6 +59,7 @@ DevToolsPowerHandler::OnStart(
scoped_refptr<DevToolsProtocol::Command> command) {
if (PowerProfilerService::GetInstance()->IsAvailable()) {
PowerProfilerService::GetInstance()->AddObserver(this);
+ is_profiling_ = true;
return command->SuccessResponse(NULL);
}
@@ -67,6 +70,7 @@ scoped_refptr<DevToolsProtocol::Response>
DevToolsPowerHandler::OnEnd(scoped_refptr<DevToolsProtocol::Command> command) {
if (PowerProfilerService::GetInstance()->IsAvailable()) {
PowerProfilerService::GetInstance()->RemoveObserver(this);
+ is_profiling_ = false;
return command->SuccessResponse(NULL);
}
@@ -97,7 +101,8 @@ DevToolsPowerHandler::OnGetAccuracyLevel(
}
void DevToolsPowerHandler::OnClientDetached() {
- PowerProfilerService::GetInstance()->RemoveObserver(this);
+ if (is_profiling_)
+ PowerProfilerService::GetInstance()->RemoveObserver(this);
}
} // namespace content
« no previous file with comments | « content/browser/devtools/devtools_power_handler.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698