Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(815)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: pylib/gyp/xcodeproj_file.py

Issue 401633002: Enable custom suffixes for Mac bundles. Base URL: http://gyp.googlecode.com/svn/trunk/
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | test/mac/gyptest-loadable-module-bundle-product-extension.py » ('j') | test/mac/gyptest-loadable-module-bundle-product-extension.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pylib/gyp/xcodeproj_file.py
===================================================================
--- pylib/gyp/xcodeproj_file.py (revision 1951)
+++ pylib/gyp/xcodeproj_file.py (working copy)
@@ -2314,11 +2314,11 @@
if force_extension is not None:
# If it's a wrapper (bundle), set WRAPPER_EXTENSION.
+ # Extension override.
+ suffix = '.' + force_extension
if filetype.startswith('wrapper.'):
self.SetBuildSetting('WRAPPER_EXTENSION', force_extension)
else:
- # Extension override.
- suffix = '.' + force_extension
self.SetBuildSetting('EXECUTABLE_EXTENSION', force_extension)
if filetype.startswith('compiled.mach-o.executable'):
« no previous file with comments | « no previous file | test/mac/gyptest-loadable-module-bundle-product-extension.py » ('j') | test/mac/gyptest-loadable-module-bundle-product-extension.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698