Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 401563002: Add a partial Mojo serial connection interface and implementation. (Closed)

Created:
6 years, 5 months ago by Sam McNally
Modified:
6 years, 5 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, chromium-apps-reviews_chromium.org, darin (slow to review), ben+mojo_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add a partial Mojo serial connection interface and implementation. This adds a Connect method to SerialService and a new partly complete Connection interface. This change includes methods for: - setting connection options - getting connection info - setting host control signals - getting device control signals - flushing buffers BUG=389016 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284399

Patch Set 1 : #

Total comments: 2

Patch Set 2 : rebase #

Patch Set 3 : address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+872 lines, -105 lines) Patch
M chrome/chrome_tests.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download
M device/device_tests.gyp View 2 chunks +2 lines, -0 lines 0 comments Download
M device/serial/BUILD.gn View 3 chunks +26 lines, -0 lines 0 comments Download
M device/serial/serial.gyp View 2 chunks +16 lines, -0 lines 0 comments Download
M device/serial/serial.mojom View 1 2 1 chunk +16 lines, -0 lines 0 comments Download
A device/serial/serial_connection.h View 1 chunk +42 lines, -0 lines 0 comments Download
A device/serial/serial_connection.cc View 1 chunk +49 lines, -0 lines 0 comments Download
A device/serial/serial_connection_factory.h View 1 chunk +48 lines, -0 lines 0 comments Download
A device/serial/serial_connection_factory.cc View 1 chunk +114 lines, -0 lines 0 comments Download
A device/serial/serial_connection_unittest.cc View 1 chunk +181 lines, -0 lines 0 comments Download
M device/serial/serial_io_handler.h View 3 chunks +6 lines, -6 lines 0 comments Download
M device/serial/serial_io_handler.cc View 2 chunks +7 lines, -7 lines 0 comments Download
M device/serial/serial_io_handler_posix.h View 1 chunk +2 lines, -1 line 0 comments Download
M device/serial/serial_io_handler_posix.cc View 2 chunks +8 lines, -4 lines 0 comments Download
M device/serial/serial_io_handler_win.h View 1 chunk +2 lines, -1 line 0 comments Download
M device/serial/serial_io_handler_win.cc View 1 2 chunks +8 lines, -4 lines 0 comments Download
M device/serial/serial_service_impl.h View 2 chunks +21 lines, -2 lines 0 comments Download
M device/serial/serial_service_impl.cc View 2 chunks +53 lines, -6 lines 0 comments Download
M device/serial/serial_service_unittest.cc View 3 chunks +102 lines, -6 lines 0 comments Download
A device/serial/test_serial_io_handler.h View 1 chunk +60 lines, -0 lines 0 comments Download
A device/serial/test_serial_io_handler.cc View 1 chunk +96 lines, -0 lines 0 comments Download
M extensions/browser/api/serial/serial_apitest.cc View 3 chunks +7 lines, -61 lines 0 comments Download
M extensions/browser/api/serial/serial_connection.cc View 2 chunks +5 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Sam McNally
6 years, 5 months ago (2014-07-17 08:53:21 UTC) #1
darin (slow to review)
serial.mojom LGTM. i'd consider adding some comments though to better explain the API flow. https://codereview.chromium.org/401563002/diff/80001/device/serial/serial.mojom ...
6 years, 5 months ago (2014-07-18 04:46:15 UTC) #2
Ken Rockot(use gerrit already)
lgtm
6 years, 5 months ago (2014-07-18 17:51:18 UTC) #3
Sam McNally
https://codereview.chromium.org/401563002/diff/80001/device/serial/serial.mojom File device/serial/serial.mojom (right): https://codereview.chromium.org/401563002/diff/80001/device/serial/serial.mojom#newcode86 device/serial/serial.mojom:86: Connection& connection_request); On 2014/07/18 04:46:15, darin wrote: > nit: ...
6 years, 5 months ago (2014-07-21 03:25:38 UTC) #4
Sam McNally
The CQ bit was checked by sammc@chromium.org
6 years, 5 months ago (2014-07-21 03:26:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sammc@chromium.org/401563002/140001
6 years, 5 months ago (2014-07-21 03:26:34 UTC) #6
commit-bot: I haz the power
6 years, 5 months ago (2014-07-21 07:18:37 UTC) #7
Message was sent while issue was closed.
Change committed as 284399

Powered by Google App Engine
This is Rietveld 408576698