Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(445)

Unified Diff: device/serial/serial_io_handler.cc

Issue 401563002: Add a partial Mojo serial connection interface and implementation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address comments Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « device/serial/serial_io_handler.h ('k') | device/serial/serial_io_handler_posix.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: device/serial/serial_io_handler.cc
diff --git a/device/serial/serial_io_handler.cc b/device/serial/serial_io_handler.cc
index df2fee4a152b569bad1729e34ecd90cbdef3f552..8945455a220f8aff6d0b792e2510c5a1e45dbade 100644
--- a/device/serial/serial_io_handler.cc
+++ b/device/serial/serial_io_handler.cc
@@ -11,8 +11,11 @@
namespace device {
-SerialIoHandler::SerialIoHandler()
- : pending_read_buffer_len_(0), pending_write_buffer_len_(0) {
+SerialIoHandler::SerialIoHandler(
+ scoped_refptr<base::MessageLoopProxy> file_thread_message_loop)
+ : pending_read_buffer_len_(0),
+ pending_write_buffer_len_(0),
+ file_thread_message_loop_(file_thread_message_loop) {
}
SerialIoHandler::~SerialIoHandler() {
@@ -20,14 +23,11 @@ SerialIoHandler::~SerialIoHandler() {
Close();
}
-void SerialIoHandler::Initialize(
- const ReadCompleteCallback& read_callback,
- const WriteCompleteCallback& write_callback,
- scoped_refptr<base::MessageLoopProxy> file_thread_message_loop) {
+void SerialIoHandler::Initialize(const ReadCompleteCallback& read_callback,
+ const WriteCompleteCallback& write_callback) {
DCHECK(CalledOnValidThread());
read_complete_ = read_callback;
write_complete_ = write_callback;
- file_thread_message_loop_ = file_thread_message_loop;
}
void SerialIoHandler::Open(const std::string& port,
« no previous file with comments | « device/serial/serial_io_handler.h ('k') | device/serial/serial_io_handler_posix.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698