Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issue 401473004: Update TestExpectation to prepare for ICU 52 upgrade (Closed)

Created:
6 years, 5 months ago by jungshik at Google
Modified:
6 years, 5 months ago
Reviewers:
tkent
CC:
blink-reviews
Project:
blink
Visibility:
Public.

Description

Update TestExpectation to prepare for ICU 52 upgrade ICU 52 has slightly different date time format for a lot of locales including en-US. A comma was added between date and time in en-US. In https://codereview.chromium.org/302323004, I made a necessary adjustment to TestExpectations, but forgot to list the following test as requiring a manual rebaseline. fast/forms/datetimelocal/datetimelocal-appearance-basic.html In addition, add back 'Android' for a few tests that require manual rebaselining after ICU 52 update. BUG=378919, 132145 TEST=datetime* tests passed as expected (fail or pass). TBR=tkent@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178398

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M LayoutTests/TestExpectations View 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jungshik at Google
I'm TBR'ing this CL because the ICU update CL ( https://codereview.chromium.org/265613002/ ) is about to ...
6 years, 5 months ago (2014-07-17 20:46:29 UTC) #1
jungshik at Google
Committed patchset #1 manually as r178398 (presubmit successful).
6 years, 5 months ago (2014-07-17 20:58:43 UTC) #2
tkent
6 years, 5 months ago (2014-07-17 23:39:48 UTC) #3
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698