DescriptionPrepare Layout tests for ICU upgrade to 52 in
A newer version of CLDR/ICU uses ',' as a delimeter between Date and Time
in en-US locale leading to the failure of a bunch of date-time-related
layout tests on Linux/Android where ICU is used to format date/time.
In addition, date time format and month names have changed in several locales,
Hindi, Russian, Arabic, and so forth.
For most of tests, rebaseline after rolling ICU to 52 would work.
They're marked as such in TestExpectations.
For the following 3 tests, a bit more changes are required.
1. fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-value-set-empty.html
- Add *-expected.txt for Linux (will also be used by Android) with a
comma.
- Marked as FAILURE in TestExpectation.
2. fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-preserve-value-after-history-back.html
- Adjusted the expected result hardcoded in the test depending on whether
the formatted field text has a comma or not.
- Add *-expected.txt for Linux (will also be used by Android) with a
comma.
- Marked as FAILURE in TestExpectation.
3. LayoutTests/fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-mouse-events.html
- Adjusted the x-coordinate of the mouse click depending on whether the
formated field text has a comma or not so that it can pass
regardless of whether a comma is present or not.
BUG=378919, 379365, 132145
TEST=datetime* and calendar-picker-related layout tests run as expected (fail or pass). After ICU roll to 52, some would pass unexpectedly.
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175442
Patch Set 1 #
Total comments: 1
Messages
Total messages: 5 (0 generated)
|