Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issue 401473003: [CSS Grid Layout] Rename gridAutoFlow[Row|Column] to gridAutoFlow[Row|Column]Sparse (Closed)

Created:
6 years, 5 months ago by Manuel Rego
Modified:
6 years, 5 months ago
CC:
blink-reviews, jfernandez, Manuel Rego, svillar
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

[CSS Grid Layout] Rename gridAutoFlow[Row|Column] to gridAutoFlow[Row|Column]Sparse Rename CSS styles in grid layout tests to make the name more explicit. As the default mode for auto-placement algorithm is "sparse". BUG=384099 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178500

Patch Set 1 #

Patch Set 2 : Keep separation between sparse and dense in the tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -72 lines) Patch
M LayoutTests/fast/css-grid-layout/grid-auto-columns-rows-auto-flow-resolution.html View 1 1 chunk +12 lines, -12 lines 0 comments Download
M LayoutTests/fast/css-grid-layout/grid-auto-flow-get-set.html View 3 chunks +8 lines, -8 lines 0 comments Download
M LayoutTests/fast/css-grid-layout/grid-auto-flow-get-set-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/css-grid-layout/grid-auto-flow-resolution.html View 1 5 chunks +8 lines, -8 lines 0 comments Download
M LayoutTests/fast/css-grid-layout/grid-auto-flow-sparse.html View 4 chunks +4 lines, -4 lines 0 comments Download
M LayoutTests/fast/css-grid-layout/grid-item-addition-auto-placement-update.html View 1 2 chunks +12 lines, -12 lines 0 comments Download
M LayoutTests/fast/css-grid-layout/grid-item-auto-placement-automatic-span.html View 1 4 chunks +4 lines, -4 lines 0 comments Download
M LayoutTests/fast/css-grid-layout/grid-item-auto-placement-definite-span.html View 1 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/css-grid-layout/grid-item-order-auto-flow-resolution.html View 1 3 chunks +6 lines, -6 lines 0 comments Download
M LayoutTests/fast/css-grid-layout/grid-item-removal-auto-placement-update.html View 1 3 chunks +10 lines, -10 lines 0 comments Download
M LayoutTests/fast/css-grid-layout/resources/grid.css View 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Manuel Rego
6 years, 5 months ago (2014-07-17 11:09:43 UTC) #1
Julien - ping for review
lgtm
6 years, 5 months ago (2014-07-18 21:27:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rego@igalia.com/401473003/20001
6 years, 5 months ago (2014-07-18 21:28:15 UTC) #3
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 5 months ago (2014-07-18 22:53:47 UTC) #4
commit-bot: I haz the power
6 years, 5 months ago (2014-07-18 23:58:02 UTC) #5
Message was sent while issue was closed.
Change committed as 178500

Powered by Google App Engine
This is Rietveld 408576698