Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(750)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 401443002: Remove unused DictionaryBuilder::createString (Closed)

Created:
6 years, 5 months ago by rwlbuis
Modified:
6 years, 5 months ago
CC:
abarth-chromium, arv+blink, blink-reviews, blink-reviews-bindings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Remove unused DictionaryBuilder::createString This was added here but does not seem used: https://codereview.chromium.org/340353006 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178308

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M Source/bindings/modules/v8/custom/V8CryptoKeyCustom.cpp View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
rwlbuis
PTAL
6 years, 5 months ago (2014-07-16 20:25:59 UTC) #1
abarth-chromium
lgtm
6 years, 5 months ago (2014-07-16 20:29:19 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/401443002/1
6 years, 5 months ago (2014-07-16 20:30:14 UTC) #3
haraken
LGTM
6 years, 5 months ago (2014-07-16 23:15:43 UTC) #4
commit-bot: I haz the power
6 years, 5 months ago (2014-07-17 03:27:20 UTC) #5
Message was sent while issue was closed. 
Change committed as 178308

Powered by Google App Engine
This is Rietveld 408576698