Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(395)

Side by Side Diff: Source/bindings/modules/v8/custom/V8CryptoKeyCustom.cpp

Issue 401443002: Remove unused DictionaryBuilder::createString (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "config.h" 5 #include "config.h"
6 #include "bindings/modules/v8/V8CryptoKey.h" 6 #include "bindings/modules/v8/V8CryptoKey.h"
7 7
8 #include "bindings/core/v8/Dictionary.h" 8 #include "bindings/core/v8/Dictionary.h"
9 #include "bindings/core/v8/V8Binding.h" 9 #include "bindings/core/v8/V8Binding.h"
10 #include "bindings/core/v8/custom/V8Uint8ArrayCustom.h" 10 #include "bindings/core/v8/custom/V8Uint8ArrayCustom.h"
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
43 43
44 virtual void setUint8Array(const char* propertyName, const blink::WebVector< unsigned char>& vector) 44 virtual void setUint8Array(const char* propertyName, const blink::WebVector< unsigned char>& vector)
45 { 45 {
46 RefPtr<Uint8Array> uint8Array = Uint8Array::create(vector.data(), vector .size()); 46 RefPtr<Uint8Array> uint8Array = Uint8Array::create(vector.data(), vector .size());
47 m_dictionary.set(propertyName, toV8(uint8Array.get(), m_holder, m_isolat e)); 47 m_dictionary.set(propertyName, toV8(uint8Array.get(), m_holder, m_isolat e));
48 } 48 }
49 49
50 const Dictionary& dictionary() const { return m_dictionary; } 50 const Dictionary& dictionary() const { return m_dictionary; }
51 51
52 private: 52 private:
53 v8::Local<v8::String> createString(const char* utf8CString)
54 {
55 return v8::String::NewFromUtf8(m_isolate, utf8CString);
56 }
57
58 v8::Handle<v8::Object> m_holder; 53 v8::Handle<v8::Object> m_holder;
59 v8::Isolate* m_isolate; 54 v8::Isolate* m_isolate;
60 Dictionary m_dictionary; 55 Dictionary m_dictionary;
61 }; 56 };
62 57
63 void V8CryptoKey::algorithmAttributeGetterCustom(const v8::PropertyCallbackInfo< v8::Value>& info) 58 void V8CryptoKey::algorithmAttributeGetterCustom(const v8::PropertyCallbackInfo< v8::Value>& info)
64 { 59 {
65 CryptoKey* impl = V8CryptoKey::toNative(info.Holder()); 60 CryptoKey* impl = V8CryptoKey::toNative(info.Holder());
66 61
67 DictionaryBuilder builder(info.Holder(), info.GetIsolate()); 62 DictionaryBuilder builder(info.Holder(), info.GetIsolate());
68 impl->key().algorithm().writeToDictionary(&builder); 63 impl->key().algorithm().writeToDictionary(&builder);
69 64
70 v8SetReturnValue(info, builder.dictionary().v8Value()); 65 v8SetReturnValue(info, builder.dictionary().v8Value());
71 } 66 }
72 67
73 } // namespace WebCore 68 } // namespace WebCore
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698