|
Revert of Sync: Refactoring of DEVICE_INFO syncable type - Part 1 ( https://codereview.chromium.org/367153005/)
Reason for revert:
this broke unit_tests" on "Linux ASan LSan Tests (2):
http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%282%29/builds/4967.
Original issue's description:
> Sync: Refactoring of DEVICE_INFO syncable type - Part 1
>
> This change introduces a new class LocalDeviceInfoProvider that is responsible
> for providing the local device specific DeviceInfo/cache_guid. It initializes
> the data asynchronously and allows consumers to get notified when the data
> becomes available.
>
> LocalDeviceInfoProvider will allow to remove these responsibilities from
> SyncedDeviceTracker / ProfileSyncService and loose coupling between
> ProfileSyncService and a number of SyncableService and DataTypeController
> derived classes.
>
> LocalDeviceInfoProvider is hosted on the frontend thread. Since it needs
> cache_guid to initialize DeviceInfo, which is currently available only on the
> backend, I updated SyncBackendHostCore and SyncBackendHostImpl to pass
> cache_guid to the frontend via OnBackendInitialized.
>
> For the time being SyncedDeviceTracker remains unchanged
> and continues to initialize the local device info too. The entire class will be
> removed in the Part 2 of the change which will move SyncedDeviceTracker
> functionality to a new SyncableService.
>
> LocalDeviceInfoProvider also replaces SessionsSyncManager::SyncInternalApiDelegate
> which was previously used to decouple SessionsSyncManager from the specifics of
> of the local device info implementation.
> SessionsSyncManager is changed to consume LocalDeviceInfoProvider instead of
> SessionsSyncManager::SyncInternalApiDelegate.
> SessionDataTypeController now also consumes LocalDeviceInfoProvider to make sure
> that SESSIONS type model doesn't start before local device info becomes available.
> A very similar approach will be used in the upcoming second part of the change
> for DEVICE_INFO DataTypeController and SyncableType.
>
> The change includes new unit tests for LocalDeviceInfoProvider and
> SessionDataTypeController.
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283461
TBR=zea@chromium.org,rlarocque@chromium.org,sky@chromium.org,maniscalco@chromium.org,stanisc@chromium.org
NOTREECHECKS=true
NOTRY=true
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283475
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+189 lines, -893 lines) |
Patch |
 |
M |
chrome/browser/extensions/api/preferences_private/preferences_private_apitest.cc
|
View
|
|
2 chunks |
+1 line, -3 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/extensions/api/sessions/sessions_apitest.cc
|
View
|
|
5 chunks |
+10 lines, -25 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/extensions/api/signed_in_devices/signed_in_devices_api.cc
|
View
|
|
3 chunks |
+1 line, -6 lines |
0 comments
|
Download
|
 |
D |
chrome/browser/sync/glue/local_device_info_provider.h
|
View
|
|
1 chunk |
+0 lines, -48 lines |
0 comments
|
Download
|
 |
D |
chrome/browser/sync/glue/local_device_info_provider_impl.h
|
View
|
|
1 chunk |
+0 lines, -39 lines |
0 comments
|
Download
|
 |
D |
chrome/browser/sync/glue/local_device_info_provider_impl.cc
|
View
|
|
1 chunk |
+0 lines, -58 lines |
0 comments
|
Download
|
 |
D |
chrome/browser/sync/glue/local_device_info_provider_mock.h
|
View
|
|
1 chunk |
+0 lines, -43 lines |
0 comments
|
Download
|
 |
D |
chrome/browser/sync/glue/local_device_info_provider_mock.cc
|
View
|
|
1 chunk |
+0 lines, -58 lines |
0 comments
|
Download
|
 |
D |
chrome/browser/sync/glue/local_device_info_provider_unittest.cc
|
View
|
|
1 chunk |
+0 lines, -82 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/sync/glue/non_frontend_data_type_controller_unittest.cc
|
View
|
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
 |
M |
chrome/browser/sync/glue/sync_backend_host_core.cc
|
View
|
|
1 chunk |
+1 line, -2 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/sync/glue/sync_backend_host_impl.h
|
View
|
|
1 chunk |
+1 line, -2 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/sync/glue/sync_backend_host_impl.cc
|
View
|
|
3 chunks |
+1 line, -4 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/sync/glue/sync_backend_host_impl_unittest.cc
|
View
|
|
2 chunks |
+2 lines, -3 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/sync/glue/sync_backend_host_mock.cc
|
View
|
|
2 chunks |
+0 lines, -3 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/sync/profile_sync_components_factory.h
|
View
|
|
2 chunks |
+0 lines, -5 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/sync/profile_sync_components_factory_impl.h
|
View
|
|
1 chunk |
+0 lines, -3 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/sync/profile_sync_components_factory_impl.cc
|
View
|
|
3 chunks |
+1 line, -12 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/sync/profile_sync_components_factory_impl_unittest.cc
|
View
|
|
2 chunks |
+12 lines, -14 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/sync/profile_sync_components_factory_mock.h
|
View
|
|
1 chunk |
+0 lines, -5 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/sync/profile_sync_components_factory_mock.cc
|
View
|
|
4 chunks |
+1 line, -17 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/sync/profile_sync_service.h
|
View
|
|
7 chunks |
+15 lines, -12 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/sync/profile_sync_service.cc
|
View
|
|
7 chunks |
+23 lines, -18 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/sync/profile_sync_service_factory.cc
|
View
|
|
1 chunk |
+5 lines, -7 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/sync/profile_sync_service_mock.h
|
View
|
|
3 chunks |
+7 lines, -4 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/sync/profile_sync_service_mock.cc
|
View
|
|
3 chunks |
+6 lines, -15 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/sync/profile_sync_service_startup_unittest.cc
|
View
|
|
2 chunks |
+2 lines, -4 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/sync/profile_sync_service_unittest.cc
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/sync/sessions/session_data_type_controller.h
|
View
|
|
3 chunks |
+1 line, -21 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/sync/sessions/session_data_type_controller.cc
|
View
|
|
6 chunks |
+5 lines, -42 lines |
0 comments
|
Download
|
 |
D |
chrome/browser/sync/sessions/session_data_type_controller_unittest.cc
|
View
|
|
1 chunk |
+0 lines, -233 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/sync/sessions/sessions_sync_manager.h
|
View
|
|
4 chunks |
+15 lines, -6 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/sync/sessions/sessions_sync_manager.cc
|
View
|
|
6 chunks |
+8 lines, -26 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/sync/sessions/sessions_sync_manager_unittest.cc
|
View
|
|
6 chunks |
+17 lines, -18 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/sync/test_profile_sync_service.h
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
chrome/browser/sync/test_profile_sync_service.cc
|
View
|
|
2 chunks |
+9 lines, -9 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/cocoa/wrench_menu/wrench_menu_controller_unittest.mm
|
View
|
|
5 chunks |
+17 lines, -15 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/sync/one_click_signin_helper_unittest.cc
|
View
|
|
2 chunks |
+1 line, -3 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/sync/one_click_signin_sync_observer_unittest.cc
|
View
|
|
2 chunks |
+1 line, -3 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/toolbar/recent_tabs_sub_menu_model_unittest.cc
|
View
|
|
4 chunks |
+19 lines, -11 lines |
0 comments
|
Download
|
 |
M |
chrome/chrome_browser.gypi
|
View
|
|
1 chunk |
+0 lines, -3 lines |
0 comments
|
Download
|
 |
M |
chrome/chrome_tests_unit.gypi
|
View
|
|
4 chunks |
+2 lines, -6 lines |
0 comments
|
Download
|
 |
M |
components/sync_driver/sync_frontend.h
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
Total messages: 3 (0 generated)
|