Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(536)

Unified Diff: chrome/browser/ui/toolbar/recent_tabs_sub_menu_model_unittest.cc

Issue 401433003: Revert of Sync: Refactoring of DEVICE_INFO syncable type - Part 1 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/sync/one_click_signin_sync_observer_unittest.cc ('k') | chrome/chrome_browser.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/toolbar/recent_tabs_sub_menu_model_unittest.cc
diff --git a/chrome/browser/ui/toolbar/recent_tabs_sub_menu_model_unittest.cc b/chrome/browser/ui/toolbar/recent_tabs_sub_menu_model_unittest.cc
index 71a2fb17657dd55d9ce54c784f4bfe6b02c39036..56be45208210745f3ad93ca5b865fca6d16f5c5e 100644
--- a/chrome/browser/ui/toolbar/recent_tabs_sub_menu_model_unittest.cc
+++ b/chrome/browser/ui/toolbar/recent_tabs_sub_menu_model_unittest.cc
@@ -12,7 +12,6 @@
#include "chrome/browser/sessions/session_types.h"
#include "chrome/browser/sessions/persistent_tab_restore_service.h"
#include "chrome/browser/sessions/tab_restore_service_factory.h"
-#include "chrome/browser/sync/glue/local_device_info_provider_mock.h"
#include "chrome/browser/sync/glue/synced_session.h"
#include "chrome/browser/sync/profile_sync_service_mock.h"
#include "chrome/browser/sync/sessions/sessions_sync_manager.h"
@@ -110,19 +109,14 @@
} // namespace
class RecentTabsSubMenuModelTest
- : public BrowserWithTestWindowTest {
+ : public BrowserWithTestWindowTest,
+ public browser_sync::SessionsSyncManager::SyncInternalApiDelegate {
public:
RecentTabsSubMenuModelTest()
- : sync_service_(&testing_profile_),
- local_device_(new browser_sync::LocalDeviceInfoProviderMock(
- "RecentTabsSubMenuModelTest",
- "Test Machine",
- "Chromium 10k",
- "Chrome 10k",
- sync_pb::SyncEnums_DeviceType_TYPE_LINUX)) {
+ : sync_service_(&testing_profile_) {
manager_.reset(new browser_sync::SessionsSyncManager(
&testing_profile_,
- local_device_.get(),
+ this,
scoped_ptr<browser_sync::LocalSessionEventRouter>(
new DummyRouter())));
manager_->MergeDataAndStartSyncing(
@@ -147,12 +141,27 @@
Profile::FromBrowserContext(browser_context), NULL);
}
+
browser_sync::OpenTabsUIDelegate* GetOpenTabsDelegate() {
return manager_.get();
}
void RegisterRecentTabs(RecentTabsBuilderTestHelper* helper) {
helper->ExportToSessionsSyncManager(manager_.get());
+ }
+
+ virtual scoped_ptr<browser_sync::DeviceInfo> GetLocalDeviceInfo()
+ const OVERRIDE {
+ return scoped_ptr<browser_sync::DeviceInfo>(
+ new browser_sync::DeviceInfo(GetLocalSyncCacheGUID(),
+ "Test Machine",
+ "Chromium 10k",
+ "Chrome 10k",
+ sync_pb::SyncEnums_DeviceType_TYPE_LINUX));
+ }
+
+ virtual std::string GetLocalSyncCacheGUID() const OVERRIDE {
+ return "RecentTabsSubMenuModelTest";
}
private:
@@ -160,7 +169,6 @@
testing::NiceMock<ProfileSyncServiceMock> sync_service_;
scoped_ptr<browser_sync::SessionsSyncManager> manager_;
- scoped_ptr<browser_sync::LocalDeviceInfoProviderMock> local_device_;
};
// Test disabled "Recently closed" header with no foreign tabs.
« no previous file with comments | « chrome/browser/ui/sync/one_click_signin_sync_observer_unittest.cc ('k') | chrome/chrome_browser.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698