Issue 401333002: Simplify a method in UpgradeDetector.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 401333002: Simplify a method in UpgradeDetector. (Closed)

Created:
6 years, 5 months ago by Alexei Svitkine (slow)

Modified:
6 years, 5 months ago

Reviewers:
sky

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Project:
chromium

Visibility:
Public.

Simplify a method in UpgradeDetector. There's only one time of badge icon now, so remove the enum that specifies the type. BUG=394855 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284569

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+4 lines, -19 lines)			Patch
M	chrome/browser/ui/toolbar/wrench_menu_model.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/browser/upgrade_detector.h	View	2 chunks	+2 lines, -10 lines	0 comments	Download
M	chrome/browser/upgrade_detector.cc	View	1 chunk	+1 line, -7 lines	0 comments	Download

Total messages: 5 (0 generated)

Alexei Svitkine (slow)

The CQ bit was checked by asvitkine@chromium.org

6 years, 5 months ago (2014-07-21 22:46:08 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asvitkine@chromium.org/401333002/1

6 years, 5 months ago (2014-07-21 22:47:51 UTC) #4

Message was sent while issue was closed.

Change committed as 284569