Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Unified Diff: chrome/browser/upgrade_detector.h

Issue 401333002: Simplify a method in UpgradeDetector. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/toolbar/wrench_menu_model.cc ('k') | chrome/browser/upgrade_detector.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/upgrade_detector.h
===================================================================
--- chrome/browser/upgrade_detector.h (revision 284446)
+++ chrome/browser/upgrade_detector.h (working copy)
@@ -33,12 +33,6 @@
UPGRADE_ANNOYANCE_CRITICAL, // Red exclamation mark.
};
- // The two types of icons we know about.
- enum UpgradeNotificationIconType {
- UPGRADE_ICON_TYPE_BADGE = 0, // For overlay badging of the wrench menu.
- UPGRADE_ICON_TYPE_MENU_ICON, // For showing in the wrench menu.
- };
-
// Returns the singleton implementation instance.
static UpgradeDetector* GetInstance();
@@ -78,10 +72,8 @@
// Retrieves the right icon ID based on the degree of severity (see
// UpgradeNotificationAnnoyanceLevel, each level has an an accompanying icon
- // to go with it). |type| determines which class of icons the caller wants,
- // either an icon appropriate for badging the wrench menu or one to display
- // within the wrench menu.
- int GetIconResourceID(UpgradeNotificationIconType type);
+ // to go with it) to display within the wrench menu.
+ int GetIconResourceID();
UpgradeNotificationAnnoyanceLevel upgrade_notification_stage() const {
return upgrade_notification_stage_;
« no previous file with comments | « chrome/browser/ui/toolbar/wrench_menu_model.cc ('k') | chrome/browser/upgrade_detector.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698