Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 401005: Mac: Draw entire Bookmark Bar every time to match API expectations. (Closed)

Created:
11 years, 1 month ago by Elliot Glaysher
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Mac: Draw entire Bookmark Bar every time to match API expectations. NtpBackgroundUtil::PaintBackgroundDetachedMode() expects to draw the entire bookmark bar on every expose; all of its internal math is based on the assumption that the incoming area is zero-based and is the whole bookmark bar area. TEST=(Repo instructions in bug) BUG=25655 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=32115

Patch Set 1 #

Patch Set 2 : Fix comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -2 lines) Patch
M chrome/browser/cocoa/bookmark_bar_toolbar_view.mm View 1 1 chunk +12 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Elliot Glaysher
11 years, 1 month ago (2009-11-16 22:54:16 UTC) #1
Amanda Walker
LGTM
11 years, 1 month ago (2009-11-16 23:02:31 UTC) #2
John Grabowski
11 years, 1 month ago (2009-11-16 23:05:27 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld 408576698