Issue 401005: Mac: Draw entire Bookmark Bar every time to match API expectations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 401005: Mac: Draw entire Bookmark Bar every time to match API expectations. (Closed)

Created:
11 years, 1 month ago by Elliot Glaysher

Modified:
9 years, 7 months ago

Reviewers:
John Grabowski, Amanda Walker

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Mac: Draw entire Bookmark Bar every time to match API expectations. NtpBackgroundUtil::PaintBackgroundDetachedMode() expects to draw the entire bookmark bar on every expose; all of its internal math is based on the assumption that the incoming area is zero-based and is the whole bookmark bar area. TEST=(Repo instructions in bug) BUG=25655 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=32115

Patch Set 1 #

Patch Set 2 : Fix comment #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -2 lines)			Patch
	M	chrome/browser/cocoa/bookmark_bar_toolbar_view.mm	View	1	1 chunk	+12 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages