Mac: Draw entire Bookmark Bar every time to match API expectations.

chrome/browser/cocoa/bookmark_bar_toolbar_view.mm

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/cocoa/bookmark_bar_toolbar_view.h"
 
 #include "app/gfx/canvas_paint.h"
 #include "app/theme_provider.h"
 #include "base/gfx/rect.h"
 #include "chrome/browser/browser_theme_provider.h"
@@ skipping 32 matching lines @@
   if (!themeProvider)
     return;
 
   NSGraphicsContext* theContext = [NSGraphicsContext currentContext];
   [theContext saveGraphicsState];
 
   // Draw the background
   {
     // CanvasPaint draws to the NSGraphicsContext during its destructor, so
     // explicitly scope this.
-    gfx::CanvasPaint canvas(rect, true);
-    gfx::Rect area(0, 0, NSWidth(rect), NSHeight(rect));
+    //
+    // Paint the entire bookmark bar, even if the damage rect is much smaller
+    // because PaintBackgroundDetachedMode() assumes that area's origin is
+    // (0, 0) and that its size is the size of the bookmark bar.
+    //
+    // In practice, this sounds worse than it is because redraw time is still
+    // minimal compared to the pause between frames of animations. We were
+    // already repainting the rest of the bookmark bar below without setting a
+    // clip area, anyway. Also, the only time we weren't asked to redraw the
+    // whole bookmark bar is when the find bar is drawn over it.
+    gfx::CanvasPaint canvas(bounds, true);
+    gfx::Rect area(0, 0, NSWidth(bounds), NSHeight(bounds));
 
     NtpBackgroundUtil::PaintBackgroundDetachedMode(themeProvider, &canvas,
         area, [controller_ currentTabContentsHeight]);
   }
 
   // Draw our bookmark bar border on top of the background.
   NSRect frameRect =
       NSMakeRect(bookmarks::kNTPBookmarkBarPadding,
                  bookmarks::kNTPBookmarkBarPadding,
                  NSWidth(bounds) - 2 * bookmarks::kNTPBookmarkBarPadding,
@@ skipping 20 matching lines @@
   NSColor* borderColor =
       [[self gtm_theme] strokeColorForStyle:GTMThemeStyleToolBarButton
                                       state:GTMThemeStateActiveWindow];
   [borderColor set];
   [border stroke];
 
   [theContext restoreGraphicsState];
 }
 
 @end  // @implementation BookmarkBarToolbarView