Issue 40083002: Make top and limit field in AllocationInfo private, assert on non-aligned setting of these fields, …

Issue 40083002: Make top and limit field in AllocationInfo private, assert on non-aligned setting of these fields, … (Closed)

Created:
7 years, 2 months ago by Hannes Payer (out of office)

Modified:
7 years, 1 month ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Make top and limit field in AllocationInfo private, assert on non-aligned setting of these fields, and eliminate indirect access over top address on top pointer. BUG= R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=17391

Patch Set 1 #

Total comments: 8

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+125 lines, -66 lines)			Patch
M	src/objects.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/spaces.h	View	7 chunks	+80 lines, -26 lines	2 comments	Download
M	src/spaces.cc	View	12 chunks	+34 lines, -31 lines	0 comments	Download
M	src/spaces-inl.h	View	2 chunks	+10 lines, -8 lines	6 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

LGTM, only nits. https://codereview.chromium.org/40083002/diff/1/src/spaces-inl.h File src/spaces-inl.h (right): https://codereview.chromium.org/40083002/diff/1/src/spaces-inl.h#newcode339 src/spaces-inl.h:339: Address new_top = allocation_info_.top() + filler_size; ...

7 years, 1 month ago (2013-10-25 08:34:55 UTC) #2

Hannes Payer (out of office)

Committed patchset #1 manually as r17391 (presubmit successful).

7 years, 1 month ago (2013-10-25 09:58:28 UTC) #3

Hannes Payer (out of office)

7 years, 1 month ago (2013-11-20 09:58:47 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/40083002/diff/1/src/spaces-inl.h
File src/spaces-inl.h (right):

https://codereview.chromium.org/40083002/diff/1/src/spaces-inl.h#newcode339
src/spaces-inl.h:339: Address new_top =  allocation_info_.top() + filler_size;
On 2013/10/25 08:34:56, Michael Starzinger wrote:
> nit: Only one white-space after assignment operator.

Done.

https://codereview.chromium.org/40083002/diff/1/src/spaces-inl.h#newcode340
src/spaces-inl.h:340: allocation_info_.set_top(new_top);
On 2013/10/25 08:34:56, Michael Starzinger wrote:
> nit: Maybe inline calculation instead of local variable.

Done.

https://codereview.chromium.org/40083002/diff/1/src/spaces-inl.h#newcode351
src/spaces-inl.h:351: allocation_info_.set_top(new_top);
On 2013/10/25 08:34:56, Michael Starzinger wrote:
> nit: Maybe inline calculation instead of local variable.

Done.

https://codereview.chromium.org/40083002/diff/1/src/spaces.h
File src/spaces.h (right):

https://codereview.chromium.org/40083002/diff/1/src/spaces.h#newcode1324
src/spaces.h:1324: ASSERT(top == NULL ||
On 2013/10/25 08:34:56, Michael Starzinger wrote:
> nit: As discussed offline, maybe consider making all of these SLOW_ASSERTs
> instead.

Done.

Expand Messages | Collapse Messages