Make top and limit field in AllocationInfo private, assert on non-aligned setting of these fields, …

src/spaces-inl.h

 // Copyright 2011 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 246 matching lines @@
   ASSERT(page->owner() == owner());
   set_prev_chunk(page);
 }
 
 
 // Try linear allocation in the page of alloc_info's allocation top.  Does
 // not contain slow case logic (e.g. move to the next page or try free list
 // allocation) so it can be used by all the allocation functions and for all
 // the paged spaces.
 HeapObject* PagedSpace::AllocateLinearly(int size_in_bytes) {
-  Address current_top = allocation_info_.top;
+  Address current_top = allocation_info_.top();
   Address new_top = current_top + size_in_bytes;
-  if (new_top > allocation_info_.limit) return NULL;
+  if (new_top > allocation_info_.limit()) return NULL;
 
-  allocation_info_.top = new_top;
+  allocation_info_.set_top(new_top);
   return HeapObject::FromAddress(current_top);
 }
 
 
 // Raw allocation.
 MaybeObject* PagedSpace::AllocateRaw(int size_in_bytes,
                                      AllocationType event) {
   HeapProfiler* profiler = heap()->isolate()->heap_profiler();
 
   HeapObject* object = AllocateLinearly(size_in_bytes);
@@ skipping 35 matching lines @@
 
   return Failure::RetryAfterGC(identity());
 }
 
 
 // -----------------------------------------------------------------------------
 // NewSpace
 
 
 MaybeObject* NewSpace::AllocateRaw(int size_in_bytes) {
-  Address old_top = allocation_info_.top;
+  Address old_top = allocation_info_.top();
 #ifdef DEBUG
   // If we are stressing compaction we waste some memory in new space
   // in order to get more frequent GCs.
   if (FLAG_stress_compaction && !heap()->linear_allocation()) {
-    if (allocation_info_.limit - old_top >= size_in_bytes * 4) {
+    if (allocation_info_.limit() - old_top >= size_in_bytes * 4) {
       int filler_size = size_in_bytes * 4;
       for (int i = 0; i < filler_size; i += kPointerSize) {
         *(reinterpret_cast<Object**>(old_top + i)) =
             heap()->one_pointer_filler_map();
       }
       old_top += filler_size;
-      allocation_info_.top += filler_size;
+      Address new_top =  allocation_info_.top() + filler_size;

[Michael Starzinger, 2013/10/25 08:34:56]

nit: Only one white-space after assignment operator.

[Hannes Payer (out of office), 2013/11/20 09:58:47]

Done.

+      allocation_info_.set_top(new_top);

[Michael Starzinger, 2013/10/25 08:34:56]

nit: Maybe inline calculation instead of local variable.

[Hannes Payer (out of office), 2013/11/20 09:58:47]

Done.

     }
   }
 #endif
 
-  if (allocation_info_.limit - old_top < size_in_bytes) {
+  if (allocation_info_.limit() - old_top < size_in_bytes) {
     return SlowAllocateRaw(size_in_bytes);
   }
 
   HeapObject* obj = HeapObject::FromAddress(old_top);
-  allocation_info_.top += size_in_bytes;
+  Address new_top = allocation_info_.top() + size_in_bytes;
+  allocation_info_.set_top(new_top);

[Michael Starzinger, 2013/10/25 08:34:56]

nit: Maybe inline calculation instead of local variable.

[Hannes Payer (out of office), 2013/11/20 09:58:47]

Done.

   ASSERT_SEMISPACE_ALLOCATION_INFO(allocation_info_, to_space_);
 
   HeapProfiler* profiler = heap()->isolate()->heap_profiler();
   if (profiler != NULL && profiler->is_tracking_allocations()) {
     profiler->NewObjectEvent(obj->address(), size_in_bytes);
   }
 
   return obj;
 }
 
@@ skipping 13 matching lines @@
   Map* map = object->map();
   Heap* heap = object->GetHeap();
   return map == heap->raw_unchecked_free_space_map()
       || map == heap->raw_unchecked_one_pointer_filler_map()
       || map == heap->raw_unchecked_two_pointer_filler_map();
 }
 
 } }  // namespace v8::internal
 
 #endif  // V8_SPACES_INL_H_