Resolve screen.orientation.lock() promise with undefined.

public/platform/WebLockOrientationCallback.h

Index: public/platform/WebLockOrientationCallback.h
diff --git a/public/platform/WebLockOrientationCallback.h b/public/platform/WebLockOrientationCallback.h
index 73cb686635d14591ab6e4a943c90101112e74352..fc721c785d531f31e64c8d946abbdb2e6cbce6b6 100644
--- a/public/platform/WebLockOrientationCallback.h
+++ b/public/platform/WebLockOrientationCallback.h
@@ -19,7 +19,11 @@ class WebLockOrientationCallback {
 public:
     virtual ~WebLockOrientationCallback() { }
 
-    virtual void onSuccess(unsigned angle, WebScreenOrientationType) = 0;
+    virtual void onSuccess(unsigned angle, WebScreenOrientationType)
+    {
+        onSuccess();
+    }
+    virtual void onSuccess() = 0;

[Michael van Ouwerkerk, 2014/07/17 16:56:24]

These being pure virtual makes modifying the interface more painful. Is this
necessary?

[abarth-chromium, 2014/07/17 18:08:46]

They don't have to be pure virtual.

[mlamouri (slow - plz ping), 2014/07/17 19:21:39]

It seems less pure with regard to design and doesn't change much given that this
interface is implemented by LockOrientationCallback which lives in Blink too.
The issue is that onSuccess(angle,type) is called from Chromium so I need to
change the Chromium side before updating the interface.

Unless I'm missing the point you guys were raising?

     virtual void onError(WebLockOrientationError) = 0;
 };