Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(415)

Issue 400573002: Reland "Remove erroneous uses of CXX / CXX_target / CXX_host from gyp." (Closed)

Created:
6 years, 5 months ago by rmcilroy
Modified:
6 years, 5 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Reland "Remove erroneous uses of CXX / CXX_target / CXX_host from gyp." The current gyp config tries to test whether the compiler is an arm / mips compiler and whether it supports -m32 / -m64 based on a test within gyp. Unfortunately CXX / CXX_target / CXX_host are no no longer set early enough in gyp for this to work, and so all of these tests were actually being done using "$(which g++)" rather than the appropriate CXX_target / CXX_host compiler. This change removes these dynamic tests and instead bases the decisions on knowledge of the host / target / v8_target architecture combination. The the -m32/-m64 flags are set based on host_cxx_is_biarch / target_cxx_is_biarch, which are set to reasonable defaults of only ia32/x64 or clang compilers being build for biarch support. The host_cxx_is_biarch / target_cxx_is_biarch variables can be overriden if required. Original Review URL: https://codereview.chromium.org/382343003 TBR=jkummerow@chromium.org BUG=384474 LOG=NO Committed: https://code.google.com/p/v8/source/detail?r=22444

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -79 lines) Patch
M build/android.gypi View 1 chunk +2 lines, -9 lines 0 comments Download
M build/toolchain.gypi View 11 chunks +74 lines, -70 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
rmcilroy
Committed patchset #1 manually as r22444 (presubmit successful).
6 years, 5 months ago (2014-07-17 09:57:06 UTC) #1
Jakob Kummerow
6 years, 5 months ago (2014-07-17 10:43:20 UTC) #2
Message was sent while issue was closed.
rubberstamp LGTM

Powered by Google App Engine
This is Rietveld 408576698