Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Issue 382343003: Remove erroneous uses of CXX / CXX_target / CXX_host from gyp. (Closed)

Created:
6 years, 5 months ago by rmcilroy
Modified:
6 years, 5 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Remove erroneous uses of CXX / CXX_target / CXX_host from gyp. The current gyp config tries to test whether the compiler is an arm / mips compiler and whether it supports -m32 / -m64 based on a test within gyp. Unfortunately CXX / CXX_target / CXX_host are no no longer set early enough in gyp for this to work, and so all of these tests were actually being done using "$(which g++)" rather than the appropriate CXX_target / CXX_host compiler. This change removes these dynamic tests and instead bases the decisions on knowledge of the host / target / v8_target architecture combination. The the -m32/-m64 flags are set based on host_cxx_is_biarch / target_cxx_is_biarch, which are set to reasonable defaults of only ia32/x64 or clang compilers being build for biarch support. The host_cxx_is_biarch / target_cxx_is_biarch variables can be overriden if required. BUG=384474 LOG=NO R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22425

Patch Set 1 : #

Total comments: 2

Patch Set 2 : Fix Indentation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -79 lines) Patch
M build/android.gypi View 1 chunk +2 lines, -9 lines 0 comments Download
M build/toolchain.gypi View 1 11 chunks +74 lines, -70 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
rmcilroy
Jacob, could you take a look please. Thanks.
6 years, 5 months ago (2014-07-15 09:36:47 UTC) #1
Jakob Kummerow
LGTM. Let's see what breaks in the wild :-) https://codereview.chromium.org/382343003/diff/40001/build/toolchain.gypi File build/toolchain.gypi (right): https://codereview.chromium.org/382343003/diff/40001/build/toolchain.gypi#newcode472 build/toolchain.gypi:472: ...
6 years, 5 months ago (2014-07-16 08:25:34 UTC) #2
rmcilroy
Thanks Jacob https://codereview.chromium.org/382343003/diff/40001/build/toolchain.gypi File build/toolchain.gypi (right): https://codereview.chromium.org/382343003/diff/40001/build/toolchain.gypi#newcode472 build/toolchain.gypi:472: ['_toolset=="target"', { On 2014/07/16 08:25:34, Jakob wrote: ...
6 years, 5 months ago (2014-07-16 09:20:26 UTC) #3
rmcilroy
6 years, 5 months ago (2014-07-16 09:23:18 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r22425 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698