Checks whether background is defined in IME extension manifest. And also move KeyEventDone logic fr…

Checks whether background is defined in IME extension manifest. And also move KeyEventDone logic from InputMethodEngine to input_ime_api.cc.

BUG=394682, 394420
TEST=Verified on linux_chromeos and Pixel device.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283755

[Shu Chen, 2014-07-17 08:24:09]

Nona, can you please review this cl? Thanks

[nona, 2014-07-17 08:43:15]

lgtm with a comment.

And thank you for the removing obsolete functions.

https://codereview.chromium.org/400523005/diff/1/chrome/browser/extensions/ap...
File chrome/browser/extensions/api/input_ime/input_ime_api.cc (right):

https://codereview.chromium.org/400523005/diff/1/chrome/browser/extensions/ap...
chrome/browser/extensions/api/input_ime/input_ime_api.cc:304: return
has_background_ && extensions::EventRouter::Get(profile_)
Could you elaborate a bit more about this logic? Perhaps good to rename this
method to "ShouldForwardKeyEvent" and add comment like as follows:

// Returns true if the extension is ready to accept key event,
// otherwise returns false.

and also good to add comment in method body:

// Need to check the background page first since  the 
// ExtensionHasEventListner returns true if the extension does
// not have a background page.

[Shu Chen, 2014-07-17 09:24:14]

https://codereview.chromium.org/400523005/diff/1/chrome/browser/extensions/ap...
File chrome/browser/extensions/api/input_ime/input_ime_api.cc (right):

https://codereview.chromium.org/400523005/diff/1/chrome/browser/extensions/ap...
chrome/browser/extensions/api/input_ime/input_ime_api.cc:304: return
has_background_ && extensions::EventRouter::Get(profile_)
On 2014/07/17 08:43:15, nona wrote:
> Could you elaborate a bit more about this logic? Perhaps good to rename this
> method to "ShouldForwardKeyEvent" and add comment like as follows:
> 
> // Returns true if the extension is ready to accept key event,
> // otherwise returns false.
> 
> and also good to add comment in method body:
> 
> // Need to check the background page first since  the 
> // ExtensionHasEventListner returns true if the extension does
> // not have a background page.

Done.

[Shu Chen, 2014-07-17 09:24:51]

The CQ bit was checked by shuchen@chromium.org

[commit-bot: I haz the power, 2014-07-17 09:25:55]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/shuchen@chromium.org/400523005/20001

[commit-bot: I haz the power, 2014-07-17 11:27:05]

Change committed as 283755