chrome/browser/chromeos/input_method/mock_input_method_engine.cc - Issue 400523005: Checks whether background is defined in IME extension manifest. And also move KeyEventDone logic fr…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/input_method/mock_input_method_engine.cc

Issue 400523005: Checks whether background is defined in IME extension manifest. And also move KeyEventDone logic fr… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: modified per comments. Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/input_method/mock_input_method_engine.h ('k') | chrome/browser/extensions/api/input_ime/input_ime_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/input_method/mock_input_method_engine.cc

diff --git a/chrome/browser/chromeos/input_method/mock_input_method_engine.cc b/chrome/browser/chromeos/input_method/mock_input_method_engine.cc

index fe104e388df5392e562cb522525b1e4982dd7a8e..2c3228a9faea7e33cde720dd8425203fe6511bfc 100644

--- a/chrome/browser/chromeos/input_method/mock_input_method_engine.cc

+++ b/chrome/browser/chromeos/input_method/mock_input_method_engine.cc

@@ -90,10 +90,6 @@ bool MockInputMethodEngine::IsActive() const {

return true;

}

-void MockInputMethodEngine::KeyEventDone(input_method::KeyEventHandle* key_data,

- bool handled) {

bool MockInputMethodEngine::DeleteSurroundingText(int context_id,

int offset,

size_t number_of_chars,