Issue 400493006: Revert 283946 "GN fixes for the Windows build."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 400493006: Revert 283946 "GN fixes for the Windows build." (Closed)

Created:
6 years, 5 months ago by Vitaly Buka (NO REVIEWS)

Modified:
6 years, 5 months ago

Reviewers:
brettw

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

Revert 283946 "GN fixes for the Windows build." Compilation error visible in try jobs of original review. > GN fixes for the Windows build. > > R=scottmg@chromium.org > TBR=scottmg > > Review URL: https://codereview.chromium.org/404603002 TBR=brettw@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283948

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+13 lines, -18 lines)			Patch
M	trunk/src/ash/BUILD.gn	View	3 chunks	+3 lines, -5 lines	0 comments	Download
M	trunk/src/ash/ash.gyp	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	trunk/src/chrome/chrome_browser_extensions.gypi	View	2 chunks	+6 lines, -4 lines	0 comments	Download
M	trunk/src/components/storage_monitor/BUILD.gn	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	trunk/src/ui/views/BUILD.gn	View	1 chunk	+2 lines, -7 lines	0 comments	Download

Total messages: 2 (0 generated)

Vitaly Buka (NO REVIEWS)

6 years, 5 months ago (2014-07-18 00:49:13 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r283948 (tree was closed).