Issue 404603002: GN fixes for the Windows build.

Issue 404603002: GN fixes for the Windows build. (Closed)

Created:
6 years, 5 months ago by brettw

Modified:
6 years, 5 months ago

Reviewers:
scottmg

CC:
chromium-reviews, extensions-reviews_chromium.org, sadrul, tfarina, chromium-apps-reviews_chromium.org, kalyank, ben+ash_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

GN fixes for the Windows build. R=scottmg@chromium.org TBR=scottmg Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283946

Patch Set 3 : typo #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -13 lines)			Patch
M	ash/BUILD.gn	View		3 chunks	+5 lines, -3 lines	0 comments	Download
M	ash/ash.gyp	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/chrome_browser_extensions.gypi	View		2 chunks	+4 lines, -6 lines	0 comments	Download
M	components/storage_monitor/BUILD.gn	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	ui/views/BUILD.gn	View	1 2	1 chunk	+7 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

scottmg

lgtm https://codereview.chromium.org/404603002/diff/1/ui/views/BUILD.gn File ui/views/BUILD.gn (right): https://codereview.chromium.org/404603002/diff/1/ui/views/BUILD.gn#newcode67 ui/views/BUILD.gn:67: "linux_ui/status_icon_linux.h", maybe is_chromeos would be better if that's ...

6 years, 5 months ago (2014-07-17 19:55:49 UTC) #2

brettw

https://codereview.chromium.org/404603002/diff/1/ui/views/BUILD.gn File ui/views/BUILD.gn (right): https://codereview.chromium.org/404603002/diff/1/ui/views/BUILD.gn#newcode67 ui/views/BUILD.gn:67: "linux_ui/status_icon_linux.h", On 2014/07/17 19:55:49, scottmg wrote: > maybe is_chromeos ...

6 years, 5 months ago (2014-07-17 20:06:00 UTC) #3

brettw

Committed patchset #3 manually as r283946 (presubmit successful).

6 years, 5 months ago (2014-07-18 00:27:41 UTC) #4

Vitaly Buka corp

6 years, 5 months ago (2014-07-18 00:45:01 UTC) #5

Message was sent while issue was closed.

A revert of this CL has been created in
https://codereview.chromium.org/406483002/ by vitalybuka@google.com.

The reason for reverting is: Does not compile for ChromeOS..

Expand Messages | Collapse Messages