Issue 40047: Make the download page focus the input field onload....

Issue 40047: Make the download page focus the input field onload.... (Closed)

Created:
11 years, 9 months ago by Glen Murphy

Modified:
5 years ago

Reviewers:
Paul Godavari

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

* Make the download page focus the input field onload.* Fix spacing between controls (Pause/Cancel).* Help deblock download UI creation (timeout in downloads.html, kMaxDownloads in downloads_ui.cc)* Allow resume for paused downloads BUG=8271, 8270, 8130, 8330 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=10863

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Total comments: 1

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+51 lines, -17 lines)			Patch
	M	chrome/browser/dom_ui/downloads_ui.cc	View		6 chunks	+17 lines, -7 lines	1 comment	Download
	M	chrome/browser/resources/downloads.html	View	1 2 3 4	9 chunks	+34 lines, -10 lines	0 comments	Download

Messages

Total messages: 6 (3 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Dan Beam

5 years ago (2015-12-11 00:25:47 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/40047/diff/11/chrome/browser/dom_ui/downloads...
File chrome/browser/dom_ui/downloads_ui.cc (right):

https://codereview.chromium.org/40047/diff/11/chrome/browser/dom_ui/downloads...
chrome/browser/dom_ui/downloads_ui.cc:28: // Maximum number of downloads to
show. TODO(glen): Remove this and instead
well, that only took 6.75 years :)

https://codereview.chromium.org/1492273002/

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages