Make the download page focus the input field onload....

chrome/browser/dom_ui/downloads_ui.cc

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/dom_ui/downloads_ui.h"
 
 #include "base/gfx/png_encoder.h"
 #include "base/string_piece.h"
 #include "base/thread.h"
 #include "base/time.h"
 #include "base/time_format.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/dom_ui/fileicon_source.h"
 #include "chrome/browser/download/download_util.h"
 #include "chrome/browser/metrics/user_metrics.h"
 #include "chrome/browser/profile.h"
 #include "chrome/common/jstemplate_builder.h"
 #include "chrome/common/l10n_util.h"
 #include "chrome/common/time_format.h"
 #include "grit/browser_resources.h"
 #include "grit/generated_resources.h"
 
 using base::Time;
 
 // DownloadsUI is accessible from chrome-ui://downloads.
 static const char kDownloadsHost[] = "downloads";
 
+// Maximum number of downloads to show. TODO(glen): Remove this and instead

[Dan Beam, 2015/12/11 00:25:47]

well, that only took 6.75 years :)

https://codereview.chromium.org/1492273002/

+// stuff the downloads down the pipe slowly.
+static const int kMaxDownloads = 150;
+
 ///////////////////////////////////////////////////////////////////////////////
 //
 // DownloadsHTMLSource
 //
 ///////////////////////////////////////////////////////////////////////////////
 
 DownloadsUIHTMLSource::DownloadsUIHTMLSource()
     : DataSource(kDownloadsHost, MessageLoop::current()) {
 }
 
@@ skipping 53 matching lines @@
 // DownloadsDOMHandler
 //
 ///////////////////////////////////////////////////////////////////////////////
 
 // Sort DownloadItems into descending order by their start time.
 class DownloadItemSorter : public std::binary_function<DownloadItem*,
                                                        DownloadItem*,
                                                        bool> {
  public:
   bool operator()(const DownloadItem* lhs, const DownloadItem* rhs) {
-    return lhs->start_time() < rhs->start_time();
+    return lhs->start_time() > rhs->start_time();
   }
 };
 
 DownloadsDOMHandler::DownloadsDOMHandler(DOMUI* dom_ui, DownloadManager* dlm)
     : DOMMessageHandler(dom_ui),
       download_manager_(dlm),
       search_text_() {
   dom_ui_->RegisterMessageCallback("getDownloads",
       NewCallback(this, &DownloadsDOMHandler::HandleGetDownloads));
   dom_ui_->RegisterMessageCallback("openFile",
       NewCallback(this, &DownloadsDOMHandler::HandleOpenFile));
 
   dom_ui_->RegisterMessageCallback("drag",
     NewCallback(this, &DownloadsDOMHandler::HandleDrag));
 
   dom_ui_->RegisterMessageCallback("saveDangerous",
     NewCallback(this, &DownloadsDOMHandler::HandleSaveDangerous));
   dom_ui_->RegisterMessageCallback("discardDangerous",
     NewCallback(this, &DownloadsDOMHandler::HandleDiscardDangerous));
   dom_ui_->RegisterMessageCallback("show",
     NewCallback(this, &DownloadsDOMHandler::HandleShow));
-  dom_ui_->RegisterMessageCallback("pause",
+  dom_ui_->RegisterMessageCallback("togglepause",
+    NewCallback(this, &DownloadsDOMHandler::HandlePause));
+  dom_ui_->RegisterMessageCallback("resume",
     NewCallback(this, &DownloadsDOMHandler::HandlePause));
   dom_ui_->RegisterMessageCallback("cancel",
     NewCallback(this, &DownloadsDOMHandler::HandleCancel));
 
   // Create our fileicon data source.
   g_browser_process->io_thread()->message_loop()->PostTask(FROM_HERE,
       NewRunnableMethod(&chrome_url_data_manager,
                         &ChromeURLDataManager::AddDataSource,
                         new FileIconSource()));
 }
@@ skipping 38 matching lines @@
     std::vector<DownloadItem*>& downloads) {
   ClearDownloadItems();
 
   // Swap new downloads in.
   download_items_.swap(downloads);
   sort(download_items_.begin(), download_items_.end(), DownloadItemSorter());
 
   // Scan for any in progress downloads and add ourself to them as an observer.
   for (OrderedDownloads::iterator it = download_items_.begin();
        it != download_items_.end(); ++it) {
+    if (static_cast<int>(it - download_items_.begin()) > kMaxDownloads)
+      break;
+
     DownloadItem* download = *it;
     if (download->state() == DownloadItem::IN_PROGRESS) {
       // We want to know what happens as the download progresses.
       download->AddObserver(this);
     } else if (download->safety_state() == DownloadItem::DANGEROUS) {
       // We need to be notified when the user validates the dangerous download.
       download->AddObserver(this);
     }
   }
 
@@ skipping 54 matching lines @@
 void DownloadsDOMHandler::HandleCancel(const Value* value) {
   DownloadItem* file = GetDownloadByValue(value);
   if (file)
     file->Cancel(true);
 }
 
 // DownloadsDOMHandler, private: ----------------------------------------------
 
 void DownloadsDOMHandler::SendCurrentDownloads() {
   ListValue results_value;
-
   for (OrderedDownloads::iterator it = download_items_.begin();
-    it != download_items_.end(); ++it) {
-      results_value.Append(CreateDownloadItemValue(*it,
-        static_cast<int>(it - download_items_.begin())));
+      it != download_items_.end(); ++it) {
+    int index = static_cast<int>(it - download_items_.begin());
+    if (index > kMaxDownloads)
+      break;
+    results_value.Append(CreateDownloadItemValue(*it,index));
   }
 
   dom_ui_->CallJavascriptFunction(L"downloadsList", results_value);
 }
 
 DictionaryValue* DownloadsDOMHandler::CreateDownloadItemValue(
     DownloadItem* download, int id) {
   DictionaryValue* file_value = new DictionaryValue();
 
-  file_value->SetInteger(L"time",
+  file_value->SetInteger(L"started",
     static_cast<int>(download->start_time().ToTimeT()));
   file_value->SetInteger(L"id", id);
   file_value->SetString(L"file_path", download->full_path().ToWStringHack());
   file_value->SetString(L"file_name", download->GetFileName().ToWStringHack());
   file_value->SetString(L"url", download->url().spec());
 
   if (download->state() == DownloadItem::IN_PROGRESS) {
     if (download->safety_state() == DownloadItem::DANGEROUS) {
       file_value->SetString(L"state", L"DANGEROUS");
     } else if (download->is_paused()) {
@@ skipping 77 matching lines @@
 }
 
 // static
 GURL DownloadsUI::GetBaseURL() {
   std::string url = DOMUIContents::GetScheme();
   url += "://";
   url += kDownloadsHost;
   return GURL(url);
 }