Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issue 400403002: Delete reduntdant 19 header files in ui/gfx of chromium (blink side) (Closed)

Created:
6 years, 5 months ago by hyunki
Modified:
6 years, 5 months ago
CC:
abarth-chromium, blink-reviews, dglazkov+blink, jamesr
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Delete reduntdant 19 header files in ui/gfx of chromium (blink side) This blink side patch has to be preceded to delete below reduntdant 19 header files in ui/gfx of chromium. (Please refer to https://codereview.chromium.org/392013005/) These header files need to be deleted since they were already moved from ui/gfx to ui/gfx/geometry. [Rendunt 19 header files to be deleted on chromium-side] ui/gfx/box_f.h ui/gfx/point.h ui/gfx/point3_f.h ui/gfx/quad_f.h ui/gfx/insets.h ui/gfx/point_f.h ui/gfx/vector2d.h ui/gfx/matrix3_f.h ui/gfx/size.h ui/gfx/size_f.h ui/gfx/rect.h ui/gfx/rect_f.h ui/gfx/rect_conversions.h ui/gfx/size_conversions.h ui/gfx/point_conversions.h ui/gfx/vector2d_conversions.h ui/gfx/safe_interget_conversions.h ui/gfx/vector3d_f.h ui/gfx/vector2d_f.h BUG=395370 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178520

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M public/platform/WebFloatPoint.h View 1 chunk +1 line, -1 line 0 comments Download
M public/platform/WebFloatPoint3D.h View 1 chunk +1 line, -1 line 0 comments Download
M public/platform/WebFloatSize.h View 1 chunk +1 line, -1 line 0 comments Download
M public/platform/WebPoint.h View 1 chunk +1 line, -1 line 0 comments Download
M public/platform/WebSize.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
hyunki
PTAL. Thank you. :)
6 years, 5 months ago (2014-07-19 14:26:07 UTC) #1
abarth-chromium
lgtm
6 years, 5 months ago (2014-07-19 17:25:22 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hyunki.baik@samsung.com/400403002/1
6 years, 5 months ago (2014-07-19 17:25:41 UTC) #3
commit-bot: I haz the power
Change committed as 178520
6 years, 5 months ago (2014-07-19 18:16:53 UTC) #4
hyunki
6 years, 5 months ago (2014-07-20 05:21:02 UTC) #5
Message was sent while issue was closed.
Thanks for the review. :)
I'll make chromium patches to get reviewed then.

Powered by Google App Engine
This is Rietveld 408576698