Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(18)

Issue 40019: Fixes regression where escape was not removing a newly bookmarked... (Closed)

Created:
9 years, 5 months ago by sky
Modified:
7 years, 3 months ago
Reviewers:
Finnur
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Fixes regression where escape was not removing a newly bookmarked page. BUG=none TEST=press the star button on a page you haven't bookmarked. The star should light up. Press escape, the bubble should close and the bookmark should be removed. Repeat with an existing bookmark and make sure pressing escape doesn't remove the bookmark. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=10803

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/browser/browser.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
sky
9 years, 5 months ago (2009-03-03 16:56:25 UTC) #1
Finnur
9 years, 5 months ago (2009-03-03 17:35:29 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698