Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3882)

Unified Diff: chrome/browser/browser.cc

Issue 40019: Fixes regression where escape was not removing a newly bookmarked... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 11 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/browser.cc
===================================================================
--- chrome/browser/browser.cc (revision 10800)
+++ chrome/browser/browser.cc (working copy)
@@ -738,11 +738,12 @@
if (url.is_empty() || !url.is_valid())
return;
+ bool was_bookmarked = model->IsBookmarked(url);
model->SetURLStarred(url, entry->title(), true);
if (window_->IsActive()) {
// Only show the bubble if the window is active, otherwise we may get into
// weird situations were the bubble is deleted as soon as it is shown.
- window_->ShowBookmarkBubble(url, model->IsBookmarked(url));
+ window_->ShowBookmarkBubble(url, was_bookmarked);
}
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698