ozone: Remove InitializeHardware / ShutdownHardware

ozone: Remove InitializeHardware / ShutdownHardware

There's lots of places to run init code:

  1. On platform creation
  2. On window creation
  3. On surface creation
  4. LoadEGLGLES2Bindings
  5. InitializeHardware

InitializeHardware has the least clear contract of the above, and is
only used for one platform, so let's remove it. The documentation is
also misleading, as it's not actually always called when the comment
says it should (prior to StartSandbox).

In order to call InitializeHardware, you need to actually build a
SurfaceFactoryOzone, so let's move the call there, so that the factory
is fully initialized right after creation and so initialization is
internal to the platform code. ShutdownHardware is never actually
called, so that part is easy.

BUG=none
TEST=ran dri & gbm on link_freon
NOTRY=true
TBR=danakj

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284813

[Ken Russell (switch to Gerrit), 2014-07-18 22:01:01]

https://codereview.chromium.org/399953003/diff/1/ui/ozone/platform/caca/caca_...
File ui/ozone/platform/caca/caca_window_manager.cc (left):

https://codereview.chromium.org/399953003/diff/1/ui/ozone/platform/caca/caca_...
ui/ozone/platform/caca/caca_window_manager.cc:128: void
CacaWindowManager::ShutdownHardware() {
There's seriously an Ozone port to libcaca?

https://codereview.chromium.org/399953003/diff/1/ui/ozone/platform/dri/dri_su...
File ui/ozone/platform/dri/dri_surface_factory.h (right):

https://codereview.chromium.org/399953003/diff/1/ui/ozone/platform/dri/dri_su...
ui/ozone/platform/dri/dri_surface_factory.h:41: // SurfaceFactoryOzone
overrides:
These aren't SurfaceFactoryOzone overrides any more. Also, please add tests for
these entry points.

[spang, 2014-07-18 22:11:11]

https://codereview.chromium.org/399953003/diff/1/ui/ozone/platform/caca/caca_...
File ui/ozone/platform/caca/caca_window_manager.cc (left):

https://codereview.chromium.org/399953003/diff/1/ui/ozone/platform/caca/caca_...
ui/ozone/platform/caca/caca_window_manager.cc:128: void
CacaWindowManager::ShutdownHardware() {
On 2014/07/18 22:01:01, Ken Russell wrote:
> There's seriously an Ozone port to libcaca?

Yeah it's been checked in since april.. we're left it here largely as sample
code.

https://codereview.chromium.org/399953003/diff/1/ui/ozone/platform/dri/dri_su...
File ui/ozone/platform/dri/dri_surface_factory.h (right):

https://codereview.chromium.org/399953003/diff/1/ui/ozone/platform/dri/dri_su...
ui/ozone/platform/dri/dri_surface_factory.h:41: // SurfaceFactoryOzone
overrides:
On 2014/07/18 22:01:01, Ken Russell wrote:
> These aren't SurfaceFactoryOzone overrides any more. Also, please add tests
for
> these entry points.

There's some already:

DriSurfaceFactoryTest.FailInitialization
DriSurfaceFactoryTest.SuccessfulInitialization

anything in particular you're worried about coverage for?

[Ken Russell (switch to Gerrit), 2014-07-18 22:37:46]

LGTM

https://codereview.chromium.org/399953003/diff/1/ui/ozone/platform/dri/dri_su...
File ui/ozone/platform/dri/dri_surface_factory.h (right):

https://codereview.chromium.org/399953003/diff/1/ui/ozone/platform/dri/dri_su...
ui/ozone/platform/dri/dri_surface_factory.h:41: // SurfaceFactoryOzone
overrides:
On 2014/07/18 22:11:11, spang wrote:
> On 2014/07/18 22:01:01, Ken Russell wrote:
> > These aren't SurfaceFactoryOzone overrides any more. Also, please add tests
> for
> > these entry points.
> 
> There's some already:
> 
> DriSurfaceFactoryTest.FailInitialization
> DriSurfaceFactoryTest.SuccessfulInitialization
> 
> anything in particular you're worried about coverage for?

OK, thanks for confirming that tests exist for these already.

[dnicoara, 2014-07-18 22:59:35]

lgtm

[spang, 2014-07-21 16:40:54]

The CQ bit was checked by spang@chromium.org

[commit-bot: I haz the power, 2014-07-21 16:42:08]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/spang@chromium.org/399953003/20001

[commit-bot: I haz the power, 2014-07-21 18:54:22]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)

[commit-bot: I haz the power, 2014-07-21 18:57:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-21 18:57:56]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)

[spang, 2014-07-21 19:55:22]

+danakj for content/browser/compositor/

[spang, 2014-07-22 23:44:28]

The CQ bit was checked by spang@chromium.org

[commit-bot: I haz the power, 2014-07-22 23:47:14]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/spang@chromium.org/399953003/100001

[commit-bot: I haz the power, 2014-07-22 23:49:26]

Change committed as 284813