Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 399923002: [WIP] Implement DOMPoint of geometry interface. (Closed)

Created:
6 years, 5 months ago by zino
Modified:
6 years, 5 months ago
CC:
arv+blink, blink-reviews, blink-reviews-dom_chromium.org, Inactive, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

[WIP] Implement DOMPoint of geometry interface. WIP The specification: http://dev.w3.org/fxtf/geometry/ Intent to Implement: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/V_bJNtOg0oM BUG=388780

Patch Set 1 #

Total comments: 7
Unified diffs Side-by-side diffs Delta from patch set Stats (+183 lines, -0 lines) Patch
M Source/core/core.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/core_generated.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
A Source/core/dom/DOMPoint.h View 1 chunk +30 lines, -0 lines 0 comments Download
A Source/core/dom/DOMPoint.idl View 1 chunk +28 lines, -0 lines 3 comments Download
A Source/core/dom/DOMPoint.js View 1 chunk +41 lines, -0 lines 4 comments Download
A Source/core/dom/DOMPointReadOnly.h View 1 chunk +28 lines, -0 lines 0 comments Download
A Source/core/dom/DOMPointReadOnly.idl View 1 chunk +16 lines, -0 lines 0 comments Download
A Source/core/dom/DOMPointReadOnly.js View 1 chunk +35 lines, -0 lines 0 comments Download
M Source/platform/RuntimeEnabledFeatures.in View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
zino
Dear @haraken, I've just uploaded CL for DOMPoint implementation. I have some questions about Blink-in-javascript. ...
6 years, 5 months ago (2014-07-17 13:54:30 UTC) #1
haraken
Thanks for working on Blink-in-JS! It looks like Blink-in-JS is missing a couple of mechanisms ...
6 years, 5 months ago (2014-07-17 15:01:59 UTC) #2
abarth-chromium
not lgtm I don't think we should use Blink-in-JS to implement these geometry interfaces. Let's ...
6 years, 5 months ago (2014-07-17 18:00:59 UTC) #3
zino
6 years, 5 months ago (2014-07-18 00:26:46 UTC) #4
On 2014/07/17 18:00:59, abarth wrote:
> not lgtm
> 
> I don't think we should use Blink-in-JS to implement these geometry
interfaces. 
> Let's get Blink-in-JS working for legacy cruft like <marquee> and XSLT first.

That's music to my ears!
I'll start to reimplement the features in C++ sides.

Powered by Google App Engine
This is Rietveld 408576698