Chromium Code Reviews| Index: chrome/browser/extensions/api/commands/command_service.cc |
| diff --git a/chrome/browser/extensions/api/commands/command_service.cc b/chrome/browser/extensions/api/commands/command_service.cc |
| index 3656f4b98830ca5dbfcde76a2b77127600157e38..ee11a07ca1a117c59f3dc1e429e9124bdfc65518 100644 |
| --- a/chrome/browser/extensions/api/commands/command_service.cc |
| +++ b/chrome/browser/extensions/api/commands/command_service.cc |
| @@ -564,6 +564,11 @@ bool CommandService::CanAutoAssign(const Command &command, |
| command.command_name() == manifest_values::kPageActionCommandEvent) |
| return false; // Browser and page actions are not global in nature. |
| + if (extension->permissions_data()->HasAPIPermission( |
| + APIPermission::kCommandsAccessibility)) { |
| + return true; |
| + } |
|
Finnur
2014/08/21 11:18:10
nit: No need for braces (single line if clause).
David Tseng
2014/08/21 16:17:56
Mixed on this one. The conditional is multiple lin
Finnur
2014/08/21 16:23:32
Yup. It is a common misunderstanding of the style
|
| + |
| // Global shortcuts are restricted to (Ctrl|Command)+Shift+[0-9]. |
| #if defined OS_MACOSX |
| if (!command.accelerator().IsCmdDown()) |