Begin whitelisting specific extensions for global key registration.

chrome/browser/extensions/api/commands/command_service.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/commands/command_service.h"
 
 #include <vector>
 
 #include "base/lazy_instance.h"
 #include "base/prefs/scoped_user_pref_update.h"
@@ skipping 546 matching lines @@
   // changed from the previous value.
   if (IsCommandShortcutUserModified(extension, command.command_name()))
     return false;
 
   if (command.global()) {
     using namespace extensions;
     if (command.command_name() == manifest_values::kBrowserActionCommandEvent ||
         command.command_name() == manifest_values::kPageActionCommandEvent)
       return false;  // Browser and page actions are not global in nature.
 
+    if (extension->permissions_data()->HasAPIPermission(
+            APIPermission::kCommandsAccessibility)) {
+      return true;
+    }

[Finnur, 2014/08/21 11:18:10]

nit: No need for braces (single line if clause).

[David Tseng, 2014/08/21 16:17:56]

Mixed on this one. The conditional is multiple lines, so generally braces are
also required? I'm ok either way. Changed to stay consistent with this file.

[Finnur, 2014/08/21 16:23:32]

Yup. It is a common misunderstanding of the style guide that because the
*conditional* is multi-line then single-line if and else clauses that follow
need braces. They don't.

+
     // Global shortcuts are restricted to (Ctrl|Command)+Shift+[0-9].
 #if defined OS_MACOSX
     if (!command.accelerator().IsCmdDown())
       return false;
 #else
     if (!command.accelerator().IsCtrlDown())
       return false;
 #endif
     if (!command.accelerator().IsShiftDown())
       return false;
@@ skipping 281 matching lines @@
   return true;
 }
 
 template <>
 void
 BrowserContextKeyedAPIFactory<CommandService>::DeclareFactoryDependencies() {
   DependsOn(ExtensionCommandsGlobalRegistry::GetFactoryInstance());
 }
 
 }  // namespace extensions