Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1692)

Unified Diff: build/android/pylib/symbols/elf_symbolizer.py

Issue 399683004: binarysize tool: Cleaning up some progress output. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/binary_size/run_binary_size_analysis.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/pylib/symbols/elf_symbolizer.py
diff --git a/build/android/pylib/symbols/elf_symbolizer.py b/build/android/pylib/symbols/elf_symbolizer.py
index 08c02d5a8ac056d8f2cf5d79f6da5e8177f8d09c..8088dfcc026aa82a87be2c6d03b5f46354d991d4 100644
--- a/build/android/pylib/symbols/elf_symbolizer.py
+++ b/build/android/pylib/symbols/elf_symbolizer.py
@@ -2,6 +2,8 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
+from __future__ import print_function
+
import collections
import datetime
import logging
@@ -13,7 +15,7 @@ import re
import subprocess
import sys
import threading
-
+import time
# addr2line builds a possibly infinite memory cache that can exhaust
# the computer's memory if allowed to grow for too long. This constant
@@ -184,12 +186,18 @@ class ELFSymbolizer(object):
def _CreateDisambiguationTable(self):
""" Non-unique file names will result in None entries"""
+ start_time = time.time()
+ print('Collecting information about available source files...',
Primiano Tucci (use gerrit) 2014/07/21 16:18:09 Please use logging.info / debug. We typically use
+ file=sys.stderr)
self.disambiguation_table = {}
for root, _, filenames in os.walk(self.source_root_path):
for f in filenames:
self.disambiguation_table[f] = os.path.join(root, f) if (f not in
self.disambiguation_table) else None
+ print('Finished collecting information about '
+ 'possible files (took %.1f s).' %
+ (time.time() - start_time), file=sys.stderr)
class Addr2Line(object):
« no previous file with comments | « no previous file | tools/binary_size/run_binary_size_analysis.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698