tools/binary_size/run_binary_size_analysis.py - Issue 399683004: binarysize tool: Cleaning up some progress output.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/binary_size/run_binary_size_analysis.py

Issue 399683004: binarysize tool: Cleaning up some progress output. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/binary_size/run_binary_size_analysis.py

diff --git a/tools/binary_size/run_binary_size_analysis.py b/tools/binary_size/run_binary_size_analysis.py

index f2c95b104fe042b38901da1732d22c39de4565a4..dd69e04170ae449f7b4bb346ef728e9452162677 100755

--- a/tools/binary_size/run_binary_size_analysis.py

+++ b/tools/binary_size/run_binary_size_analysis.py

@@ -540,7 +540,7 @@ def RunElfSymbolizer(outfile, library, addr2line_binary, nm_binary, jobs,

sys.stdout.write('\r%.1f%%: Looked up %d symbols (%d collisions, '

'%d disambiguations where %.1f%% succeeded)'

- '- %.1f lookups/s.' %

+ ' - %.1f lookups/s.' %

(progress_percent, progress.count, progress.collisions,

progress.disambiguations, disambiguation_percent, speed))

@@ -617,7 +617,6 @@ def RunElfSymbolizer(outfile, library, addr2line_binary, nm_binary, jobs,

def RunNm(binary, nm_binary):

- print('Starting nm')

cmd = [nm_binary, '-C', '--print-size', '--size-sort', '--reverse-sort',

binary]

nm_process = subprocess.Popen(cmd,

@@ -631,7 +630,6 @@ def RunNm(binary, nm_binary):

else:

raise Exception, process_output

- print('Finished nm')

return process_output