Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 399683004: binarysize tool: Cleaning up some progress output. (Closed)

Created:
6 years, 5 months ago by Daniel Bratell
Modified:
6 years, 3 months ago
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

binarysize tool: Cleaning up some progress output. R=primiano BUG= Committed: https://crrev.com/42cab11e12ec82915197f300d26007f30b959c6b Cr-Commit-Position: refs/heads/master@{#292999}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Use logging instead of print. #

Total comments: 2

Patch Set 3 : Added empty line #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M build/android/pylib/symbols/elf_symbolizer.py View 1 2 2 chunks +6 lines, -0 lines 0 comments Download
M tools/binary_size/run_binary_size_analysis.py View 1 3 chunks +1 line, -3 lines 0 comments Download

Messages

Total messages: 9 (1 generated)
Daniel Bratell
6 years, 5 months ago (2014-07-21 14:40:31 UTC) #1
Primiano Tucci (use gerrit)
https://codereview.chromium.org/399683004/diff/1/build/android/pylib/symbols/elf_symbolizer.py File build/android/pylib/symbols/elf_symbolizer.py (right): https://codereview.chromium.org/399683004/diff/1/build/android/pylib/symbols/elf_symbolizer.py#newcode190 build/android/pylib/symbols/elf_symbolizer.py:190: print('Collecting information about available source files...', Please use logging.info ...
6 years, 5 months ago (2014-07-21 16:18:10 UTC) #2
Daniel Bratell
primiano, please take a new look at this. Now with logging instead of print.
6 years, 3 months ago (2014-09-02 14:37:28 UTC) #3
Primiano Tucci (use gerrit)
LGTM % 1 nit https://codereview.chromium.org/399683004/diff/20001/build/android/pylib/symbols/elf_symbolizer.py File build/android/pylib/symbols/elf_symbolizer.py (right): https://codereview.chromium.org/399683004/diff/20001/build/android/pylib/symbols/elf_symbolizer.py#newcode16 build/android/pylib/symbols/elf_symbolizer.py:16: import time Nit: you need ...
6 years, 3 months ago (2014-09-02 17:10:52 UTC) #4
Daniel Bratell
https://codereview.chromium.org/399683004/diff/20001/build/android/pylib/symbols/elf_symbolizer.py File build/android/pylib/symbols/elf_symbolizer.py (right): https://codereview.chromium.org/399683004/diff/20001/build/android/pylib/symbols/elf_symbolizer.py#newcode16 build/android/pylib/symbols/elf_symbolizer.py:16: import time On 2014/09/02 17:10:52, Primiano Tucci wrote: > ...
6 years, 3 months ago (2014-09-02 19:48:40 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bratell@opera.com/399683004/40001
6 years, 3 months ago (2014-09-02 19:54:56 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001) as d3b14eaa67d4086859fafc36114f2faefd8e0ff0
6 years, 3 months ago (2014-09-02 21:20:56 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:20:50 UTC) #9
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/42cab11e12ec82915197f300d26007f30b959c6b
Cr-Commit-Position: refs/heads/master@{#292999}

Powered by Google App Engine
This is Rietveld 408576698