Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Unified Diff: tools/binary_size/run_binary_size_analysis.py

Issue 399683004: binarysize tool: Cleaning up some progress output. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added empty line Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/android/pylib/symbols/elf_symbolizer.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/binary_size/run_binary_size_analysis.py
diff --git a/tools/binary_size/run_binary_size_analysis.py b/tools/binary_size/run_binary_size_analysis.py
index 23869e0f64cbdfe659eebd310633d990e0cc96c9..71c0975627a78f4e6e4aaf71812c9695fa97ce09 100755
--- a/tools/binary_size/run_binary_size_analysis.py
+++ b/tools/binary_size/run_binary_size_analysis.py
@@ -541,7 +541,7 @@ def RunElfSymbolizer(outfile, library, addr2line_binary, nm_binary, jobs,
sys.stdout.write('\r%.1f%%: Looked up %d symbols (%d collisions, '
'%d disambiguations where %.1f%% succeeded)'
- '- %.1f lookups/s.' %
+ ' - %.1f lookups/s.' %
(progress_percent, progress.count, progress.collisions,
progress.disambiguations, disambiguation_percent, speed))
@@ -618,7 +618,6 @@ def RunElfSymbolizer(outfile, library, addr2line_binary, nm_binary, jobs,
def RunNm(binary, nm_binary):
- print('Starting nm')
cmd = [nm_binary, '-C', '--print-size', '--size-sort', '--reverse-sort',
binary]
nm_process = subprocess.Popen(cmd,
@@ -632,7 +631,6 @@ def RunNm(binary, nm_binary):
else:
raise Exception, process_output
- print('Finished nm')
return process_output
« no previous file with comments | « build/android/pylib/symbols/elf_symbolizer.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698