Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4352)

Unified Diff: chrome/browser/resources/chromeos/login/login_common.js

Issue 399613002: Anti-shelf-overlapping fixes for several menus. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/chromeos/login/login_common.js
diff --git a/chrome/browser/resources/chromeos/login/login_common.js b/chrome/browser/resources/chromeos/login/login_common.js
index e8ea73dacc08fe92ff3e4c092d085f6c9b4172de..decb008e8ec5885dc6a1572d3c431ae70a576dab 100644
--- a/chrome/browser/resources/chromeos/login/login_common.js
+++ b/chrome/browser/resources/chromeos/login/login_common.js
@@ -327,6 +327,21 @@ cr.define('cr.ui', function() {
Oobe.getInstance().setClientAreaSize(width, height);
};
+ /**
+ * Computes max-height for an element so that it doesn't overlap shelf.
+ * @param {element} DOM element
+ */
+ Oobe.getMaxHeightBeforeShelfOverlapping = function(element) {
+ var maxAllowedHeight =
+ parseInt(window.getComputedStyle($('outer-container')).height) -
+ element.getBoundingClientRect().top -
+ parseInt(window.getComputedStyle(element).marginTop) -
+ parseInt(window.getComputedStyle(element).marginBottom) -
+ parseInt(window.getComputedStyle(element).paddingTop) -
+ parseInt(window.getComputedStyle(element).paddingBottom);
+ return maxAllowedHeight;
dzhioev (left Google) 2014/07/16 19:13:50 I don't like this approach. It has many problems:
merkulova 2014/07/22 08:11:44 Done.
+ }
+
// Export
return {
Oobe: Oobe

Powered by Google App Engine
This is Rietveld 408576698