Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5424)

Unified Diff: chrome/browser/resources/chromeos/login/network_dropdown.js

Issue 399613002: Anti-shelf-overlapping fixes for several menus. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/chromeos/login/network_dropdown.js
diff --git a/chrome/browser/resources/chromeos/login/network_dropdown.js b/chrome/browser/resources/chromeos/login/network_dropdown.js
index 3a5a3f5fe79dc2c7362c89a2ee7d4d659b948a4f..f6e5a54800e9f9e6ef09abdafbf5b7f2744f94ff 100644
--- a/chrome/browser/resources/chromeos/login/network_dropdown.js
+++ b/chrome/browser/resources/chromeos/login/network_dropdown.js
@@ -173,6 +173,11 @@ cr.define('cr.ui', function() {
this.createItem_(this.container, item);
}
this.container.selectItem(this.container.firstItem, false);
+
+ var maxHeight = Oobe.getMaxHeightBeforeShelfOverlapping(
+ this.container);
+ if (maxHeight < parseInt(window.getComputedStyle(this.container).height))
+ this.container.style.maxHeight = maxHeight + 'px';
dzhioev (left Google) 2014/07/16 19:13:51 Are you sure that accessing to CSS properties with
merkulova 2014/07/22 08:11:44 Well... it's accessed from js like this.
},
/**

Powered by Google App Engine
This is Rietveld 408576698