Anti-shelf-overlapping fixes for several menus.

A11y options list and remove supervised user menu are moved up in case of shelf-overlapping. Network list gets scrollbar in that case.

Also remove supervised user button aligned.

BUG=382851
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287801

[dzhioev (left Google), 2014-07-16 19:13:51]

https://codereview.chromium.org/399613002/diff/1/chrome/browser/resources/chr...
File chrome/browser/resources/chromeos/login/login_common.js (right):

https://codereview.chromium.org/399613002/diff/1/chrome/browser/resources/chr...
chrome/browser/resources/chromeos/login/login_common.js:342: return
maxAllowedHeight;
I don't like this approach. It has many problems:  doesn't work for hidden
elements, returned value depends on 'box-sizing' value, height can have 'auto'
value, maybe something else. Let's discuss offline if we can do it better.

https://codereview.chromium.org/399613002/diff/1/chrome/browser/resources/chr...
File chrome/browser/resources/chromeos/login/network_dropdown.js (right):

https://codereview.chromium.org/399613002/diff/1/chrome/browser/resources/chr...
chrome/browser/resources/chromeos/login/network_dropdown.js:180:
this.container.style.maxHeight = maxHeight + 'px';
Are you sure that accessing to CSS properties with ".camelCasePropertyName"
syntax is standard?

https://codereview.chromium.org/399613002/diff/1/chrome/browser/resources/log...
File chrome/browser/resources/login/user_pod_row.css (right):

https://codereview.chromium.org/399613002/diff/1/chrome/browser/resources/log...
chrome/browser/resources/login/user_pod_row.css:326: .action-box-area.active ~
.action-box-menu:not(.menuMovedUp) {
menu-moved-up

[merkulova, 2014-07-22 08:11:44]

https://codereview.chromium.org/399613002/diff/1/chrome/browser/resources/chr...
File chrome/browser/resources/chromeos/login/login_common.js (right):

https://codereview.chromium.org/399613002/diff/1/chrome/browser/resources/chr...
chrome/browser/resources/chromeos/login/login_common.js:342: return
maxAllowedHeight;
On 2014/07/16 19:13:50, dzhioev wrote:
> I don't like this approach. It has many problems:  doesn't work for hidden
> elements, returned value depends on 'box-sizing' value, height can have 'auto'
> value, maybe something else. Let's discuss offline if we can do it better.

Done.

https://codereview.chromium.org/399613002/diff/1/chrome/browser/resources/chr...
File chrome/browser/resources/chromeos/login/network_dropdown.js (right):

https://codereview.chromium.org/399613002/diff/1/chrome/browser/resources/chr...
chrome/browser/resources/chromeos/login/network_dropdown.js:180:
this.container.style.maxHeight = maxHeight + 'px';
On 2014/07/16 19:13:51, dzhioev wrote:
> Are you sure that accessing to CSS properties with ".camelCasePropertyName"
> syntax is standard?

Well... it's accessed from js like this.

https://codereview.chromium.org/399613002/diff/1/chrome/browser/resources/log...
File chrome/browser/resources/login/user_pod_row.css (right):

https://codereview.chromium.org/399613002/diff/1/chrome/browser/resources/log...
chrome/browser/resources/login/user_pod_row.css:326: .action-box-area.active ~
.action-box-menu:not(.menuMovedUp) {
On 2014/07/16 19:13:51, dzhioev wrote:
> menu-moved-up

Done.

[dzhioev (left Google), 2014-07-24 13:27:30]

On 2014/07/22 08:11:44, merkulova wrote:
>
https://codereview.chromium.org/399613002/diff/1/chrome/browser/resources/chr...
> File chrome/browser/resources/chromeos/login/login_common.js (right):
> 
>
https://codereview.chromium.org/399613002/diff/1/chrome/browser/resources/chr...
> chrome/browser/resources/chromeos/login/login_common.js:342: return
> maxAllowedHeight;
> On 2014/07/16 19:13:50, dzhioev wrote:
> > I don't like this approach. It has many problems:  doesn't work for hidden
> > elements, returned value depends on 'box-sizing' value, height can have
'auto'
> > value, maybe something else. Let's discuss offline if we can do it better.
> 
> Done.
> 
>
https://codereview.chromium.org/399613002/diff/1/chrome/browser/resources/chr...
> File chrome/browser/resources/chromeos/login/network_dropdown.js (right):
> 
>
https://codereview.chromium.org/399613002/diff/1/chrome/browser/resources/chr...
> chrome/browser/resources/chromeos/login/network_dropdown.js:180:
> this.container.style.maxHeight = maxHeight + 'px';
> On 2014/07/16 19:13:51, dzhioev wrote:
> > Are you sure that accessing to CSS properties with ".camelCasePropertyName"
> > syntax is standard?
> 
> Well... it's accessed from js like this.
> 
>
https://codereview.chromium.org/399613002/diff/1/chrome/browser/resources/log...
> File chrome/browser/resources/login/user_pod_row.css (right):
> 
>
https://codereview.chromium.org/399613002/diff/1/chrome/browser/resources/log...
> chrome/browser/resources/login/user_pod_row.css:326: .action-box-area.active ~
> .action-box-menu:not(.menuMovedUp) {
> On 2014/07/16 19:13:51, dzhioev wrote:
> > menu-moved-up
> 
> Done.

LGTM

[merkulova, 2014-07-24 14:40:11]

Added coverage for freshly discovered cases.
Have one more look. 

thanks.

[dzhioev (left Google), 2014-07-24 17:44:24]

On 2014/07/24 14:40:11, merkulova wrote:
> Added coverage for freshly discovered cases.
> Have one more look. 
> 
> thanks.

Last patch set doesn't work for action box menu. http://goo.gl/ox36Rh

[Nikita (slow), 2014-07-24 20:41:03]

refactoring heads up: 
https://codereview.chromium.org/402403005/

[Nikita (slow), 2014-07-25 09:27:17]

On 2014/07/24 20:41:03, Nikita Kostylev wrote:
> refactoring heads up: 
> https://codereview.chromium.org/402403005/

Refactoring CL has landed.

[merkulova, 2014-07-25 09:50:24]

To "Last patch set doesn't work for action box menu. http://goo.gl/ox36Rh":

It wasn't planned to change action box menu code. Changes apply only to elements
that have possibility to overlap the shelf. Currently there's no need for it for
action box menu. Especially regarding the fact that approach is not scalable.

[dzhioev (left Google), 2014-07-25 12:17:00]

https://codereview.chromium.org/399613002/diff/60001/ui/login/account_picker/...
File ui/login/account_picker/user_pod_row.css (right):

https://codereview.chromium.org/399613002/diff/60001/ui/login/account_picker/...
ui/login/account_picker/user_pod_row.css:335: -webkit-transform: rotate(180deg);
> It wasn't planned to change action box menu code. Changes apply
> only to elements that have possibility to overlap the shelf. 
> Currently there's no need for it for action box menu. Especially
> regarding the fact that approach is not scalable.
Then why these changes were made?

[merkulova, 2014-07-28 11:59:51]

Refactored and checked on desktop.

[merkulova, 2014-07-31 12:31:46]

ping

[dzhioev (left Google), 2014-08-01 16:26:13]

LGTM, after these addressed:

https://codereview.chromium.org/399613002/diff/80001/ui/login/login_ui_tools.js
File ui/login/login_ui_tools.js (right):

https://codereview.chromium.org/399613002/diff/80001/ui/login/login_ui_tools....
ui/login/login_ui_tools.js:11: function LoginUiTools() {
nit: 'Ui' looks ugly. I prefer LoginUITools

https://codereview.chromium.org/399613002/diff/80001/ui/login/login_ui_tools....
ui/login/login_ui_tools.js:11: function LoginUiTools() {
LoginUITools shouldn't be a function, object will be enough.

[merkulova, 2014-08-04 06:39:29]

https://codereview.chromium.org/399613002/diff/80001/ui/login/login_ui_tools.js
File ui/login/login_ui_tools.js (right):

https://codereview.chromium.org/399613002/diff/80001/ui/login/login_ui_tools....
ui/login/login_ui_tools.js:11: function LoginUiTools() {
On 2014/08/01 16:26:13, dzhioev wrote:
> nit: 'Ui' looks ugly. I prefer LoginUITools

Done.

https://codereview.chromium.org/399613002/diff/80001/ui/login/login_ui_tools....
ui/login/login_ui_tools.js:11: function LoginUiTools() {
On 2014/08/01 16:26:13, dzhioev wrote:
> LoginUITools shouldn't be a function, object will be enough.

Done.

[merkulova, 2014-08-06 07:34:10]

ping

[Nikita (slow), 2014-08-06 07:49:37]

removing myself from reviewers (just gave a heads up on refactoring).

[merkulova, 2014-08-06 09:26:20]

The CQ bit was checked by merkulova@chromium.org

[commit-bot: I haz the power, 2014-08-06 09:27:08]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/merkulova@chromium.org/399613002/100001

[commit-bot: I haz the power, 2014-08-06 11:54:59]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  win8_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...)

[commit-bot: I haz the power, 2014-08-06 11:57:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-06 11:57:45]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Nikita (slow), 2014-08-06 11:58:24]

lgtm

[Nikita (slow), 2014-08-06 11:58:27]

The CQ bit was checked by nkostylev@chromium.org

[commit-bot: I haz the power, 2014-08-06 12:00:07]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/merkulova@chromium.org/399613002/100001

[merkulova, 2014-08-06 13:07:02]

The CQ bit was unchecked by merkulova@chromium.org

[merkulova, 2014-08-06 13:31:09]

The CQ bit was checked by merkulova@chromium.org

[commit-bot: I haz the power, 2014-08-06 13:32:15]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/merkulova@chromium.org/399613002/120001

[commit-bot: I haz the power, 2014-08-06 17:30:11]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_chromium_gn_compile_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)

[commit-bot: I haz the power, 2014-08-06 17:40:41]

Change committed as 287801