chrome/browser/resources/chromeos/login/oobe.js - Issue 399613002: Anti-shelf-overlapping fixes for several menus.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/chromeos/login/oobe.js

Issue 399613002: Anti-shelf-overlapping fixes for several menus. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Css fixes intersecting with another CL removed. Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/resources/chromeos/login/oobe.js

diff --git a/chrome/browser/resources/chromeos/login/oobe.js b/chrome/browser/resources/chromeos/login/oobe.js

index 3626967929c5208a75c7b792ca79fc95382e55fc..218ed000dc3cec4cc3a0b7634af5886ca50db21e 100644

--- a/chrome/browser/resources/chromeos/login/oobe.js

+++ b/chrome/browser/resources/chromeos/login/oobe.js

@@ -146,6 +146,15 @@ cr.define('cr.ui.Oobe', function() {

$('accessibility-menu').showForElement(e.target,

cr.ui.Bubble.Attachment.BOTTOM,

BUBBLE_OFFSET, BUBBLE_PADDING);

+ var maxHeight = cr.ui.LoginUITools.getMaxHeightBeforeShelfOverlapping(

+ $('accessibility-menu'));

+ if (maxHeight < $('accessibility-menu').offsetHeight) {

+ $('accessibility-menu').showForElement(e.target,

+ cr.ui.Bubble.Attachment.TOP,

+ BUBBLE_OFFSET, BUBBLE_PADDING);

+ }

$('accessibility-menu').firstBubbleElement = $('spoken-feedback');

$('accessibility-menu').lastBubbleElement = $('close-accessibility-menu');

if (Oobe.getInstance().currentScreen &&