[Password Generation] Trigger confirmation bubble when a password is saved

chrome/browser/ui/views/passwords/manage_passwords_icon_view.cc

Index: chrome/browser/ui/views/passwords/manage_passwords_icon_view.cc
diff --git a/chrome/browser/ui/views/passwords/manage_passwords_icon_view.cc b/chrome/browser/ui/views/passwords/manage_passwords_icon_view.cc
index 42457d001978e73f58b838eedd5bac30851dd331..87215ba63e2001b5b508cd53758abbfcce2abb01 100644
--- a/chrome/browser/ui/views/passwords/manage_passwords_icon_view.cc
+++ b/chrome/browser/ui/views/passwords/manage_passwords_icon_view.cc
@@ -53,12 +53,10 @@ void ManagePasswordsIconView::UpdateVisibleUI() {
   SetImage(ui::ResourceBundle::GetSharedInstance().GetImageSkiaNamed(icon_id_));
   SetTooltipText(l10n_util::GetStringUTF16(tooltip_text_id_));
 
-  if (password_manager::ui::PENDING_PASSWORD_AND_BUBBLE_STATE) {

[Mike West, 2014/07/17 13:43:17]

This is probably a good change, but what was the bug here that you mentioned? :)

[Garrett Casto, 2014/07/17 20:54:55]

Should be if (state() == ....). Should be something that the compiler catches,
but I guess it's not trivial since you want to support the "do {} while(0)" case
for macros.

-    // We're about the automatically pop up a ManagePasswordsBubbleView.
-    // Force layout of the icon's parent now; the bubble will be incorrectly
-    // positioned otherwise, as the icon won't have been drawn into position.
-    parent()->Layout();
-  }
+  // We may be about to automatically pop up a ManagePasswordsBubbleView.
+  // Force layout of the icon's parent now; the bubble will be incorrectly
+  // positioned otherwise, as the icon won't have been drawn into position.
+  parent()->Layout();
 }
 
 bool ManagePasswordsIconView::IsBubbleShowing() const {