[Password Generation] Trigger confirmation bubble when a password is saved

chrome/browser/ui/views/passwords/manage_passwords_icon_view.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/passwords/manage_passwords_icon_view.h"
 
 #include "chrome/app/chrome_command_ids.h"
 #include "chrome/browser/command_updater.h"
 #include "chrome/browser/ui/passwords/manage_passwords_ui_controller.h"
 #include "chrome/browser/ui/view_ids.h"
@@ skipping 35 matching lines @@
   if (state() == password_manager::ui::BLACKLIST_STATE)
     icon_id_ = active() ? IDR_SAVE_PASSWORD_DISABLED_ACTIVE
                         : IDR_SAVE_PASSWORD_DISABLED_INACTIVE;
   else if (password_manager::ui::IsPendingState(state()))
     tooltip_text_id_ = IDS_PASSWORD_MANAGER_TOOLTIP_SAVE;
 
   SetVisible(true);
   SetImage(ui::ResourceBundle::GetSharedInstance().GetImageSkiaNamed(icon_id_));
   SetTooltipText(l10n_util::GetStringUTF16(tooltip_text_id_));
 
-  if (password_manager::ui::PENDING_PASSWORD_AND_BUBBLE_STATE) {

[Mike West, 2014/07/17 13:43:17]

This is probably a good change, but what was the bug here that you mentioned? :)

[Garrett Casto, 2014/07/17 20:54:55]

Should be if (state() == ....). Should be something that the compiler catches,
but I guess it's not trivial since you want to support the "do {} while(0)" case
for macros.

-    // We're about the automatically pop up a ManagePasswordsBubbleView.
-    // Force layout of the icon's parent now; the bubble will be incorrectly
-    // positioned otherwise, as the icon won't have been drawn into position.
-    parent()->Layout();
-  }
+  // We may be about to automatically pop up a ManagePasswordsBubbleView.
+  // Force layout of the icon's parent now; the bubble will be incorrectly
+  // positioned otherwise, as the icon won't have been drawn into position.
+  parent()->Layout();
 }
 
 bool ManagePasswordsIconView::IsBubbleShowing() const {
   return ManagePasswordsBubbleView::IsShowing();
 }
 
 void ManagePasswordsIconView::OnExecuting(
     BubbleIconView::ExecuteSource source) {
 }